Repository navigation
Generate editor declarations without the TypeScript compiler - #741
Merged
Merged
Conversation
- Emit the SQLite SDK and services client declaration files directly from their generators, byte-identical to the previous compiler output. - Hold both generators to declaration emit across SQLite column classes and service shapes, and keep the shipped SDK declarations fresh in the test suite.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.native/cache/sqlite/core.d.ts) and the services editor client declarations (node_modules/@native-sdk/services/index.d.ts) are now written directly by the generators that already produce their sources, instead of by running a TypeScript compiler program over the generated code.sqlite_cli.tsno longer loads the TypeScript compiler, andnative checkno longer compiles a program just to emit editor typings.sdk/core.d.ts, so the existing freshness test for the shipped SDK declarations is added to thezig buildNode test step alongside the new tests.