[v5.0] fix(ci): make Playwright apt retries recover - #19140
Merged
Merged
Conversation
## Background The Test RSC e2e job failed three times on August 19 while Playwright installed Chromium system dependencies: - https://github.com/vercel/ai/actions/runs/32226175669/job/95987241660 - https://github.com/vercel/ai/actions/runs/32296621196/job/96210594834 - https://github.com/vercel/ai/actions/runs/32302334578/job/96228309554 In each run, apt-get update stalled against azure.archive.ubuntu.com until the 15-minute timeout. Playwright had spawned apt-get through a nested sudo process, so apt-get survived the timeout and retained /var/lib/apt/lists/lock. The retry guard only watched /var/lib/dpkg/lock-frontend, causing attempts two and three to fail immediately. This matches the active GitHub runner-images incident: actions/runner-images#14594 ## Summary - run Playwright and its timeout as root so apt-get remains in the timeout process group - add apt acquisition timeouts and a bounded retry so stalled mirrors fail over promptly - wait for the apt lists, archives, and dpkg locks before every attempt - report an explicit error if locks remain held for five minutes ## End-to-End Verification This is a CI-only change. The intermittent mirror timeout cannot be forced locally; this pull request CI exercises the normal Test RSC e2e path. The timeout path now keeps the Playwright process and its privileged apt descendants in one process group and checks the exact lock observed in all three failures before retrying. ## Validation - pnpm check - pnpm type-check:full - workflow YAML parsing - embedded Bash syntax check - git diff --check ## Checklist - [x] All commits are signed (PRs with unsigned commits cannot be merged) - [ ] Tests have been added / updated (for bug fixes / features) - [ ] Documentation has been added / updated (for bug fixes / features) - [ ] A patch changeset for relevant packages has been added (for bug fixes / features - run pnpm changeset in the project root) - [x] I have reviewed this pull request (self-review) ## Related Issues - actions/runner-images#14594 - actions/runner-images#14596
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Backport of #19133 to the actively maintained v5 release branch. The linked v5 RSC e2e failure showed the Playwright dependency install outliving the outer timeout, retaining an apt lock, and making every retry fail immediately.
Failure: https://github.com/vercel/ai/actions/runs/32302334578/job/96228309554
Summary
Validation
No changeset: this only changes CI infrastructure.