Allow TypeScript configs that set allowImportingTsExtensions - #1343
Open
Hashim1999164 wants to merge 1 commit into
Open
Allow TypeScript configs that set allowImportingTsExtensions#1343Hashim1999164 wants to merge 1 commit into
Hashim1999164 wants to merge 1 commit into
Conversation
ncc already forces noEmit false to emit JavaScript, which then fails with TS5096 when the project also enabled allowImportingTsExtensions. Ignore that config diagnostic and keep emitDeclarationOnly off so .ts import specifiers still typecheck.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1146
ncc already forces noEmit false so it can emit JavaScript. User tsconfig files that set allowImportingTsExtensions with noEmit true then fail with TS5096.
Keep emitting JavaScript, clear emitDeclarationOnly, and ignore TS5096 when the project enabled allowImportingTsExtensions so .ts import specifiers still typecheck.