fix: resolve ESM-only package exports maps (fixes #1311) - #1344
Draft
QuarkOS wants to merge 1 commit into
Draft
Conversation
Packages whose exports map has only `import`/`types` (no `require` or `default`), such as @actions/core 3.x, failed with "Package path . is not exported" when webpack resolved them as CommonJS. Include `import` in CJS conditionNames so those packages can be bundled. `require` stays first so dual packages still prefer their CJS entry when it is listed first. Fixes vercel#1311 Co-authored-by: Emilio Schwaiger <QuarkOS@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1311.
Problem
ncc failed to compile packages whose
package.jsonexportsmap hasimport/typesbut nodefault/require(for example@actions/core3.x /@github/core).Webpack CJS resolution only allowed
require,node, andproduction/development. ESM-only packages never matched, including when the build itself was ESM and a CJS file in the graph usedrequire().Direct
importof those packages already worked on current main. The failure is CJS-style resolution of an import-only exports map.Change
Add
importto CJSconditionNames.requirestays first so dual packages still prefer their CJS entry when that condition is listed first.Test
New
test/unit/exports-import-onlyfixture: ESM project (type: module) that loads a CJS wrapper whichrequire()s a package with onlytypes+importexports.