Conversation
Package specifiers always use `/`, so concatenating a scoped name or an `exports` target into a path yields `…\node_modules\@scope/pkg` on Windows. Comparisons against a sep-joined prefix — `inPath()` while walking symlinks — then fail, and the `node_modules` symlink of a scoped package is never emitted, leaving a standalone deployment without it. Only CommonJS was unaffected, because `resolveDir()` happens to pass its paths through `resolve()`; the ESM branch of `validateAndResolvePaths()` keeps them verbatim. Translate separators where a specifier becomes a path instead. Signed-off-by: Oldřich Jedlička <oldium.pro@gmail.com>
oldium
requested review from
a team,
icyJoseph,
ijjk and
styfle
as code owners
August 30, 2026 19:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Package specifiers always use
/, so concatenating a scoped name or anexportstarget into a path yields…\node_modules\@scope/pkgon Windows. Comparisons against a sep-joined prefix —inPath()while walking symlinks — then fail, and thenode_modulessymlink of a scoped package is never emitted, leaving a standalone deployment without it.Only CommonJS was unaffected, because
resolveDir()happens to pass its paths throughresolve(); the ESM branch ofvalidateAndResolvePaths()keeps them verbatim. Translate separators where a specifier becomes a path instead.