Conversation
Reverts half of vercel#568. Closes vercel#607. Basically, vercel#568 does two things while stating it does one: 1. Ignore any paths outside the job's root 2. Ignore any paths emitted by a `node_modules` file which sit outside that same `node_modules` These were both introduced to fix some problems with sveltekit including things like `/bin` and what not. However, only the first is needed for that. The second change seems unnecessary and breaks a lot of common patterns (e.g. the `dotenv` one in the newly added test).
43081j
requested review from
a team,
icyJoseph,
ijjk and
styfle
as code owners
September 2, 2026 11:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts half of #568.
Closes #607.
Fixes #606.
Basically, #568 does two things while stating it does one:
node_modulesfile which sit outside that samenode_modulesThese were both introduced to fix some problems with sveltekit including things like
/binand what not. However, only the first is needed for that.The second change seems unnecessary and breaks a lot of common patterns (e.g. the
dotenvone in the newly added test).