Skip to content

test: use fs.watch for the async leak fixture #11099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sheremet-va merged 1 commit into from
Aug 29, 2026
Merged

test: use fs.watch for the async leak fixture #11099

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 22 additions & 18 deletions test/e2e/test/detect-async-leaks.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,35 +212,39 @@ test('fetch', async () => {
`)
})

test('fs handle', async () => {
test('fs watcher', async () => {
const { stderr } = await runInlineTests({
'packages/example/test/example.test.ts': `
import { readFile } from 'node:fs'
import { watch } from 'node:fs'

test('leaking fs handle', () => {
readFile(import.meta.filename, () => {});
test('leaking fs watcher', () => {
watch(import.meta.filename, () => {});
})
`,
'packages/example/test/example-2.test.ts': `
import { readFile } from 'node:fs'
import { watch } from 'node:fs'

test('not a leak', async () => {
await new Promise(resolve => readFile(import.meta.filename, () => { resolve() }));
test('not a leak', () => {
watch(import.meta.filename, () => {}).close();
})
`,
})

// This might be racy. Sometimes readFile fires two FSREQCALLBACK's, sometimes just one.
expect(stderr).toContain(`\
FSREQCALLBACK leaking in packages/example/test/example.test.ts
3|
4| test('leaking fs handle', () => {
5| readFile(import.meta.filename, () => {});
| ^
6| })
7|
❯ packages/example/test/example.test.ts:5:9
`)
expect(stderr).toMatchInlineSnapshot(`
"
⎯⎯⎯⎯⎯⎯⎯ Async Leaks 1 ⎯⎯⎯⎯⎯⎯⎯⎯

FSEVENTWRAP leaking in packages/example/test/example.test.ts
3|
4| test('leaking fs watcher', () => {
5| watch(import.meta.filename, () => {});
| ^
6| })
7|
❯ packages/example/test/example.test.ts:5:9

"
`)
})

test('http server', async () => {
Expand Down
Loading