Skip to content

refactor: use 'slices.Backward' for backward slice loop #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tenthirtyam merged 1 commit into from
Aug 31, 2026
Merged

refactor: use 'slices.Backward' for backward slice loop #554

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions builder/vmware/common/driver_parser.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import (
"os"
"reflect"
"regexp"
"slices"
"sort"
"strconv"
"strings"
Expand Down Expand Up @@ -956,12 +957,12 @@ func createDeclaration(node pDeclaration) ConfigDeclaration {
result.hostid = make([]pParameterClientMatch, 0)

// walk from globals to pDeclaration collecting all parameters
for i := len(hierarchy) - 1; i >= 0; i-- {
for i, h := range slices.Backward(hierarchy) {
result.composites = append(result.composites, hierarchy[(len(hierarchy)-1)-i])
result.id = append(result.id, hierarchy[(len(hierarchy)-1)-i].id)

// update configDeclaration parameters
for _, p := range hierarchy[i].parameters {
for _, p := range h.parameters {
switch p := p.(type) {
case pParameterOption:
result.options[p.name] = p.value
Expand Down
Loading