Fix DiffSinger rendering (Phonemizer & Multi-Speaker) & Misc. - #287
Open
KahazaTester wants to merge 1 commit into
Open
Fix DiffSinger rendering (Phonemizer & Multi-Speaker) & Misc.#287KahazaTester wants to merge 1 commit into
KahazaTester wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request: DiffSinger Engine Fixes, Singer Import Auto-Detection & L10n Fallback
This should fix the following issues: #277 #280
Summary of Changes
1. DiffSinger Renderer & Phonemizer Fixes
np.dotCrashes (DiffSingerSpeakerEmbedManager.cs):np.dotmatrix multiplication in bothPhraseSpeakerEmbedByFrame(rendering) andPhraseSpeakerEmbedByPhone(duration model phonemization) with managed per-frame normalized weighting and direct float buffer copies, fixingNullReferenceExceptioncrashes on mobile runtimes.DiffSingerBasePhonemizer.cs):GetSpeakerAtIndex(tone+color match -> color match -> first defined subbank) to correctly resolve singers with named voice colors on default notes.DiffSingerG2pPhonemizer.cs):!string.IsNullOrEmpty(langCode)instead ofuseLangId, ensuring voicebanks withuse_lang_id: falsecorrectly map G2P phonemes to<langCode>/<phoneme>.2. Singer Import Auto-Detection (
ClassicSingerSetupViewModel.cs)singer_typeincharacter.yaml:dsconfig.yaml-> setsSingerType = "diffsinger".enuconfig.yaml-> setsSingerType = "enunu"."utau"otherwise.3. Localization Default (
LocalizationManager.cs)SystemLanguageFallbackCodefromzh-Hanstoenso unrecognized system languages default to English on first start.Verification