Skip to content

feat: add multi-intensity LED support #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thomas-brunel wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: add multi-intensity LED support #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 63 additions & 0 deletions src/led.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,33 @@ void led_free(led_t *led) {
free(led);
}

int led_get_multi_intensity(led_t *led, unsigned int *red, unsigned int *green, unsigned int *blue) {
char led_path[P_PATH_MAX];
char buf[16];
int fd, ret;

snprintf(led_path, sizeof(led_path), "/sys/class/leds/%s/multi_intensity", led->name);

if ((fd = open(led_path, O_RDONLY)) < 0)
return _led_error(led, LED_ERROR_IO, errno, "Opening LED 'multi_intensity'");

if ((ret = read(fd, buf, sizeof(buf) - 1)) < 0) {
int errsv = errno;
close(fd);
return _led_error(led, LED_ERROR_IO, errsv, "Reading LED 'multi_intensity'");
}

buf[ret] = '\0';

if (close(fd) < 0)
return _led_error(led, LED_ERROR_IO, errno, "Closing LED 'multi_intensity'");

if (sscanf(buf, "%u %u %u", red, green, blue) != 3)
return _led_error(led, LED_ERROR_IO, 0, "Invalid LED 'multi_intensity' value");

return 0;
}

int led_get_brightness(led_t *led, unsigned int *brightness) {
char led_path[P_PATH_MAX];
char buf[16];
Expand Down Expand Up @@ -264,6 +291,42 @@ int led_get_triggers_count(led_t *led, unsigned int *count) {
return 0;
}

int led_set_multi_intensity(led_t *led, unsigned int red, unsigned int green, unsigned int blue) {
char led_path[P_PATH_MAX];
char buf[16];
int fd, len;

if (red > 255) {
return _led_error(led, LED_ERROR_ARG, 0, "Red out of bounds (max is 255)");
}

if (green > 255) {
return _led_error(led, LED_ERROR_ARG, 0, "Green out of bounds (max is 255)");
}

if (blue > 255) {
return _led_error(led, LED_ERROR_ARG, 0, "blue out of bounds (max is 255)");
}

snprintf(led_path, sizeof(led_path), "/sys/class/leds/%s/multi_intensity", led->name);

if ((fd = open(led_path, O_WRONLY)) < 0)
return _led_error(led, LED_ERROR_IO, errno, "Opening LED 'multi_intensity'");

len = snprintf(buf, sizeof(buf), "%u %u %u\n", red, green, blue);

if (write(fd, buf, len) < 0) {
int errsv = errno;
close(fd);
return _led_error(led, LED_ERROR_IO, errsv, "Writing LED 'multi_intensity'");
}

if (close(fd) < 0)
return _led_error(led, LED_ERROR_IO, errno, "Closing LED 'multi_intensity'");

return 0;
}

int led_set_brightness(led_t *led, unsigned int brightness) {
char led_path[P_PATH_MAX];
char buf[16];
Expand Down
2 changes: 2 additions & 0 deletions src/led.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,15 @@ int led_close(led_t *led);
void led_free(led_t *led);

/* Getters */
int led_get_multi_intensity(led_t *led, unsigned int *red, unsigned int *green, unsigned int *blue);
int led_get_brightness(led_t *led, unsigned int *brightness);
int led_get_max_brightness(led_t *led, unsigned int *max_brightness);
int led_get_trigger(led_t *led, char *str, size_t len);
int led_get_triggers_entry(led_t *led, unsigned int index, char *str, size_t len);
int led_get_triggers_count(led_t *led, unsigned int *count);

/* Setters */
int led_set_multi_intensity(led_t *led, unsigned int red, unsigned int green, unsigned int blue);
int led_set_brightness(led_t *led, unsigned int brightness);
int led_set_trigger(led_t *led, const char *trigger);

Expand Down
15 changes: 15 additions & 0 deletions tests/test_led.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@ void test_open_config_close(void) {
unsigned int max_brightness;
unsigned int brightness;
unsigned int triggers_count;
unsigned int red;
unsigned int green;
unsigned int blue;
bool value;

ptest();
Expand All @@ -50,6 +53,18 @@ void test_open_config_close(void) {
passert(led_get_max_brightness(led, &max_brightness) == 0);
passert(max_brightness > 0);

/* Check multi-intensity values */
passert(led_set_multi_intensity(led, 1, 2, 3) == 0);
usleep(10000);
passert(led_get_multi_intensity(led, &red, &green, &blue) == 0);
passert(red == 1);
passert(green == 2);
passert(blue == 3);
passert(led_set_multi_intensity(led, 256, 0, 0) == LED_ERROR_ARG);
passert(led_set_multi_intensity(led, 0, 256, 0) == LED_ERROR_ARG);
passert(led_set_multi_intensity(led, 0, 0, 256) == LED_ERROR_ARG);
passert(led_set_multi_intensity(led, 0, 0, 0) == 0);

/* Check setting invalid brightness */
passert(led_set_brightness(led, max_brightness + 1) == LED_ERROR_ARG);

Expand Down