Repository navigation
Conversation
After a send, the delegate and the exits are renewed over what is held, once the indexer reflects the send. That waited only for the inputs to be gone: in between that and the change being listed, the held set is empty or short of the change, counted as settled, and the renewal went over it. The change then had no exit, and after a last send the wallet had no delegate at all: the e2e's "every renewal signs an exit for every VTXO it covers" and "three sends Alice to Bob" failed on it, on a busy machine every time. A send with change now also waits for it to arrive: arkTxid:1, as the cosigner orders an ark transaction's outputs (recipient, change, anchor). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a send, the wallet renews its delegate and exits over what it holds, once the indexer reflects the send. The wait was finished as soon as the inputs were gone.
The bug. Between the inputs disappearing and the change being listed, the held set is empty, or short of the change. That counted as settled, so the renewal went over funds without the change:
This is the
heldOnceIndexedrace noted in #60. The e2e's "every renewal signs an exit for every VTXO it covers" and "board, settle, and three sends Alice to Bob" failed on it. On a busy machine they failed every time: both, in two runs out of two.The fix. A send that leaves change now also waits for the change itself. It is
arkTxid:1, since the cosigner orders an ark transaction's outputs recipient, change, anchor (SendSession::change_vtxo). This uses thearrivedwait the boarding path already has.Checked:
core's tests: 168 pass.make e2eon this branch: 25 of 25, both of those tests included.🤖 Generated with Claude Code