chore: add issue forms, a PR template and CODEOWNERS - #93
Merged
Merged
Conversation
`.github/` held scripts/ and workflows/ and nothing else, and the ecosystem drift log has carried this as a deferred item since 2026-09-07. The forms matter more here than they would for a library. A result depends on the GPU, the driver, the CUDA version, the capability, the cuda-oxide commit, the nightly, and which of the three backends produced the number -- docs/LIMITATIONS.md has a whole section on that -- so a free-text "the tuner picked a slow configuration" is unactionable, and the same report with its provenance block is a bug. Three forms: a wrong convergence verdict in either direction, which is the report that matters most since refusing a fast configuration IS the product; a measurement that disagrees with what you see; and the known hole where a gate-clean candidate still fails the real compile. Blank issues off. A finding wrong about the kernel rather than the launch shape is pointed at reconverge, which this project ships and does not reimplement. Signed-off-by: Vyncint Ng <chivy.nguyen@manabie.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.github/heldscripts/andworkflows/and nothing else. NoISSUE_TEMPLATE/, nopull_request_template.md, noCODEOWNERS. The ecosystem drift log has carried "launchbound issue templates … no template directory observed" as a deferred item since 2026-09-07.Why forms rather than free text
More than for a library, because of what a report here has to contain before anyone can act on it. A result depends on the GPU, the driver version, the CUDA version, the compute capability, the cuda-oxide commit, the nightly, and which of the three backends produced the number —
docs/LIMITATIONS.mdhas a whole section ("Results do not port") on precisely that. "The tuner picked a slow configuration" is the start of a conversation; the same report with its provenance block is a bug.Three forms:
compute-sanitizer synccheckreport, a lane argument.docs/LIMITATIONS.mdalready documents under "cuda-oxide is alpha" —cargo checkunder the reconverge driver does not evaluate all codegen-time consts. Each report names another one.Blank issues are off, and the config links a wrong kernel verdict to reconverge, which this project ships as a component and does not reimplement.
The PR checklist carries the two things a contributor here can only learn by being told: a change that moves a measured number needs a
bench:changelog entry naming the hardware, and the lockstep pin set moves in a commit of its own.Closes #80