Repository navigation
test: return Result from clicking_without_mouse_tracking_is_a_typed_error - #550
Merged
Merged
Conversation
…rror The other 25 tests in input.rs return termlens::Result<()> and use ?, as the skill's rule 9 asks. This was the one test that used unwrap() four times. The unwrap_err() on the click stays, since that error is the thing under test. Signed-off-by: Cestercian <183791452+cestercian@users.noreply.github.com>
vyncint
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
clicking_without_mouse_tracking_is_a_typed_errorwas the one test incrates/termlens/tests/input.rsthat did not returntermlens::Result<()>. The other 25 do, and SKILL.md rule 9 asks tests to. The fourunwrap()s (spawn,wait_until,send,wait_exit) become?and the test ends withOk(()). Theunwrap_err()on the click stays, since that error is the thing under test.Closes #544
Checklist
cargo fmt --allandcargo clippy --workspace --all-targets --all-featuresare clean (clippy run on-p termlens --tests)git commit -s)CHANGELOG.mdupdated under[Unreleased](user-facing changes only): n/a, test-onlycargo insta review, not blind-accepted: n/acargo test -p termlens --test input clicking_without_mouse_trackingpasses.