Skip to content

test: return Result from clicking_without_mouse_tracking_is_a_typed_error - #550

Merged
vyncint merged 1 commit into
vyncint:mainfrom
cestercian:test/input-typed-error-result
Oct 2, 2026
Merged

vyncint merged 1 commit into
vyncint:mainfrom
cestercian:test/input-typed-error-result

Conversation

@cestercian

Copy link
Copy Markdown
Contributor

What & why

clicking_without_mouse_tracking_is_a_typed_error was the one test in crates/termlens/tests/input.rs that did not return termlens::Result<()>. The other 25 do, and SKILL.md rule 9 asks tests to. The four unwrap()s (spawn, wait_until, send, wait_exit) become ? and the test ends with Ok(()). The unwrap_err() on the click stays, since that error is the thing under test.

Closes #544

Checklist

  • Linked an issue (or explained above why none exists)
  • Tests added/updated for the change
  • cargo fmt --all and cargo clippy --workspace --all-targets --all-features are clean (clippy run on -p termlens --tests)
  • All commits are signed off (git commit -s)
  • No AI attribution trailers
  • CHANGELOG.md updated under [Unreleased] (user-facing changes only): n/a, test-only
  • Snapshot changes (if any) were reviewed with cargo insta review, not blind-accepted: n/a

cargo test -p termlens --test input clicking_without_mouse_tracking passes.

…rror

The other 25 tests in input.rs return termlens::Result<()> and use ?, as the skill's rule 9 asks. This was the one test that used unwrap() four times. The unwrap_err() on the click stays, since that error is the thing under test.

Signed-off-by: Cestercian <183791452+cestercian@users.noreply.github.com>
@cestercian
cestercian requested a review from vyncint as a code owner October 1, 2026 19:28
@vyncint
vyncint merged commit 42c4e1c into vyncint:main Oct 2, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test: make clicking_without_mouse_tracking_is_a_typed_error return Result like its 25 siblings

2 participants