Repository navigation
Conversation
…lid each skill-built-supported-arm failed evaluation with union.disconnected. Its smoke exemption said a dedicated test covered a hinge visibility failure, but that test is an it.skip placeholder, so the example had no evaluate coverage. - Upper link (6 solids): the shoulder root stopped 1 mm short of the beam, the shoulder cheeks were 3.5 mm off it, and the elbow cheeks were 7.5 mm past the beam end. One shoulder hub now spans both cheeks and overlaps the beam; the elbow cheeks run back to a cross bridge that ends at x = 103, the same limit as the beam, outside the forearm root swing. - Gripper palm (5 solids): the hinge lugs only touched the palm face. The palm now runs 1 mm into the lugs; a finger at 30 degrees still clears it by 1.75 mm. - Connectors, mates and limits are unchanged. validate --include-interference reports the same mechanism findings before and after (issue #352), and no interference finding. - Evaluate the example in the fast smoke suite. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: w1ne <41898282+w1ne@users.noreply.github.com>
Signed-off-by: w1ne <41898282+w1ne@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
examples/robot-arm/skill-built-supported-arm.kcad.tsfailedevaluatewithunion.disconnected. The fast smoke suite exempted it with the reason "dedicated authoring test covers this existing hinge visibility failure". That reason is stale:tests/integration/examples/skillBuiltSupportedArm.test.tsis anit.skipplaceholder, so the example had no evaluate coverage.Reproduction (origin/develop
80f7542be)Change
EVALUATION_EXEMPT, so the fast smoke suite evaluates it.Results
evaluate: before exit 1 (1 error, 1 warning); after exit 0,OK.npx vitest run tests/integration/fast/exampleParseSmoke.test.ts -t "supported-arm|classifies": 5 passed, includingskill-built-supported-arm.kcad.ts evaluates cleanly(1.6 s).validate --include-interference, before and after: exit 2 both times, with the same mechanism findings (shoulder mate gap 2.0 mm, finger mate gap 1.5 mm, coupling residual, drops-on-release; tracked by Example examples/robot-arm/skill-built-supported-arm.kcad.ts fails the physics-grounded loop #352). No interference finding before or after. Diff of the two reports: the palm-to-finger-pivot distance drops from 4.0 to 3.0 mm, and the free passive finger drift changes from 228 to 229 mm.npx eslinton the changed test file: clean.Not done
print-prep/wall-hook.kcad.tsfails at its documenteddfm.fdm.overhang-unsupportedgate and could move toEXPECTED_FAILURE. Thekinematic/luxo-lamp.kcad.tsexemption reason is also stale: it now fails onunion.member-overlapandunion.disconnected, not hinge visibility.🤖 Generated with Claude Code
Demo handoff
Local
kernelcad render inspectremains unavailable because Playwright Chromium is absent. The hosted preview and MP4 provide visual geometry evidence only; the preview reports #352 joint diagnostics, and no mechanism pass is claimed. The video caption states that five targeted smoke checks passed and that verification was skipped. The bundle retains the raw turntable, caption source, rendering script, source hash, and inspected frame.