Repository navigation
Conversation
`kernelcad evaluate examples/kinematic/luxo-lamp.kcad.ts` failed with 5 union.disconnected and 5 union.member-overlap errors, while the mechanism validate test still passed. The smoke test exempted it with a stale "hinge visibility" reason. - Fuse each arm's beam, spring posts and new distal yoke before one .material() call; same for the head neck stem, fat neck and post. - Add a fork-width yoke at each beam end so the elbow and wrist fork plates (outboard of the 14 mm beam) are carried by the link. - Start both beams 2 mm inside their clevis tongue. - Stand the shoulder spring mast on the base disc; the clevis pocket removes the column top under it. - Carry the shade on the neck stem, the socket on the shade wall, and the wrist post on the stem. - Shorten the shoulder spring rest length 36 -> 34 mm to restore the drop-test margin (3.7 deg drift vs 3.8 deg on develop; limit 5 deg). Remove the smoke-test exemption so evaluate stays covered. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: w1ne <41898282+w1ne@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: w1ne <41898282+w1ne@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
examples/kinematic/luxo-lamp.kcad.tsnow evaluates cleanly. On develop,kernelcad evaluatefails with 10 errors (5union.disconnected, 5union.member-overlap). The mechanismvalidatetest still passes, so the smoke test exempted the file with a stale "hinge visibility" reason, and nothing detected the defect.Reproduction (develop
80f7542be)npx tsx src/agent/cli/index.ts evaluate examples/kinematic/luxo-lamp.kcad.ts --json # ok:false, 10 union errorsRoot causes and changes (example source only)
.material()and overlap a body that uses the same material.material()oncerestLengthMm36 → 34 mm: 3.7° drift (develop 3.8°)The
luxo-lampexemption is removed fromtests/integration/fast/exampleParseSmoke.test.ts, soevaluateis now covered (1.6 s; budget 15 s).Results
evaluate:ok:true, 106 features, 0 diagnostics.validate --include-physics --include-interference:mechanism: real. 8 poses across 3 joints, no collisions, holds under gravity.exampleParseSmoke -t 'luxo-lamp|classifies': 3 passed.KCAD_SLOW=1luxoLampClevis.{test,validate.test,mjcf.test}+exampleSweepGate: 11 passed.scripts/typecheckExamples.ts: no errors in this file. The existing errors are in other files.Demo
docs/demos/luxo-lamp-connected-solids-20261113/demo.mp4: a static local turntable that I inspected visually (frames at 0.5 s and 3 s). Provenance and hashes are incapture-settings.json. The dark shade colour is the same on develop.Limits
Gallery artifacts under
docs/demos/gallery/luxo-lamp/are not regenerated. The tendon co-calibration follow-up noted in the source remains open.🤖 Generated with Claude Code