Repository navigation
Conversation
… failure Three portfolio watch examples were exempt from the evaluate smoke test with "uses removed legacy arm.fixed API". - pocket-watch-v2 already evaluates clean; drop the stale exemption. - pocket-watch and watch-from-screenshot-agent-loop-v2 threw "watch.fixed is not a function". Add the same connector-pair + 'fastened' mate shim that pocket-watch-v2 uses (typed `as const`). - pocket-watch then hit feature.subtractive-noop: the lanyard cutter (top z 23.6 mm) never reached the torus (z 28.95-35.05 mm). Remove the no-op cutter; the ring stays whole, as it always evaluated, and the bail post enters its bottom. - Re-parent mates whose declared parent never touched the child: minute hand -> hour hand, pinion cap -> minute hand (pocket-watch validate now ok), spring-bar end caps -> their spring bar, dial -> rehaut. print-prep/wall-hook is an intentional FDM-overhang demonstration. Move it from the exemption list to EXPECTED_FAILURE, pinned to its documented 938.2 mm2 '+z' overhang diagnostic. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: w1ne <41898282+w1ne@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: w1ne <41898282+w1ne@users.noreply.github.com>
Signed-off-by: w1ne <41898282+w1ne@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR closes four of the remaining unclaimed
EVALUATION_EXEMPTentries intests/integration/fast/exampleParseSmoke.test.ts. Three portfolio watch examples now evaluate cleanly and are tested. The wall-hook example is now pinned to its intended failure.Reproduction (develop
80f7542be)Changes
pocket-watch/build.kcad.ts,watch-from-screenshot-agent-loop-v2.kcad.tswatch.fixedAPI'fastened'mate shim thatpocket-watch-v2already uses, typedas constpocket-watch/build.kcad.tsfeature.subtractive-noop: the lanyard cutter (top at z 23.6 mm) never reached the torus (z 28.95–35.05 mm)pocket-watch/build.kcad.tsvalidate:mechanism.mate-gap, minute hand 1.15 mm and pinion cap 1.65 mm from their declared parent (the dial)watch-from-screenshot-agent-loop-v2.kcad.tsexampleParseSmoke.test.tsprint-prep/wall-hooktoEXPECTED_FAILURE, pinned todfm.fdm.overhang-unsupportedwith "938.2 mm² … '+z' up", the exact output documented in the fileNo engine code changes.
Results
evaluate: pocket-watchok:true, 227 features (one info-levelauthoring.prefer-api.hole-by-cylinder). Wristwatchok:true, 364 features, 0 diagnostics.validate: pocket-watchok:true, 0 mechanism failures (statusunverified, the same aspocket-watch-v2).exampleParseSmoke.test.tsfull file: 260/260 passed (73.5 s). Targeted run: pocket-watch 1.2 s, pocket-watch-v2 1.5 s, wristwatch 1.3 s, wall-hook 0.3 s; budget 15 s.scripts/typecheckExamples.ts: errors in the changed files fall from 41 to 27 (pocket-watch) and from 75 to 50 (wristwatch). All 45TS2339(fixedmissing) are gone. The remaining implicit-any/string | numbererrors are pre-existing.Demo
docs/demos/portfolio-watches-evaluate-20261113/demo.mp4: a 6 s static local pocket-watch turntable. I inspected frames at 0.5 s (front: dial, screws, hands, whole ring on the bail post) and 3 s (rear: the yellow case back shows through the open frame pocket, as designed). Provenance and hashes are incapture-settings.json.Limits
validatestill reportsmechanism: broken: 6 mate gaps (lug feet 1.11 mm and spring bars 1.21 mm from their parents) and pre-existing interferences (crystal through dial ticks, bezel and case back into the case band). I tried lengthening the spring bars into the lug ears. It removed the gaps but created new bar/ear/cap overlaps, because the ears have no bar holes. I reverted it; a correct fix needs a lug redesign.build.mp4,build.stl,hero-frame.png) are not regenerated.🤖 Generated with Claude Code