Repository navigation
chore: stop tracking regenerable demo frames and review sheets - #1387
Merged
Merged
Conversation
Remove artifacts/catalog-demos/*/frames and the generated images and script-written JSON under artifacts/catalog-demos/*/video-review. Each bundle's capture script rebuilds frames and the MP4, and its inspect script rebuilds the decoded frames and contact sheet from the MP4. Add ignore rules so regenerating them leaves the tree clean, replace links to the removed files with the regeneration command, and keep hand-written review notes and video-review directories that have no committed generator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Stops tracking regenerable demo intermediates under
artifacts/catalog-demos/:*/frames/(all files): the PNG slides each bundle's capture script encodes into its MP4.*/video-review/generated images (decoded frames, contact sheets, sampled frames) and the script-writtenvideo-inspection.json/review.json, for every bundle whose own script writes that directory.1,233 files removed. MP4s, posters, bundle READMEs, generator/inspect scripts and all other evidence stay.
Size
Tracked blob sizes (
git ls-tree -r -l):That is 132.1 MB and 1,233 files fewer in the working tree. History is not rewritten: the old blobs remain in git history, so clone size is unchanged.
Kept tracked on purpose
video-review/(visual-review.md,inspection-notes.md,inspection.json): not produced by any script.video-review/contents of 21 bundles whose scripts do not write that directory (ad-hoc ffmpeg sampling; about 12 MB incl. the notes above). Without a committed generator they are not regenerable, so they stay.frames.ffconcat/frames.txtlist files at bundle root (small, rewritten by the capture scripts, contain absolute paths from the original machine).Regeneration
Each affected bundle README gets an "Untracked generated outputs" section naming its capture and inspect commands. Ignore rules in
.gitignorecoverframes/,video-review/**/*.png,video-review/video-inspection.json,video-review/review.json, so regenerated output does not show up ingit status(the capture scripts still re-encode the tracked MP4 and poster).Dangling references
video-review/contact-sheet.pngorframes/...as strings (video-inspection.json,verification.json,settings.json) are left as written: the scripts emit those strings, and nothing reads them back.<a>/<img>and reference definitions): 111 dangling links before, 111 after, none introduced (the 111 pre-existing ones are untouched; 11 are under or intoartifacts/).src,tests,scripts,.github, vite configs orpackage.jsonreads these paths;npm pack --dry-runincludes noartifacts/file.catalog/kits/*/README.mdlinks only point at bundle READMEs and scripts, which still exist.Verified
npm run typecheck,npm run qc:lint(lint + cookbook validate): pass.vitest:scripts/repoHygieneAudit.test.ts,tests/integration/catalog/catalogIndex.test.ts(index drift),tests/unit/architecture: 12 tests pass.airfield-wave-20261102andmarine-wave-20261102: removedframes/andvideo-review/, ran the capture then inspect script, which recreated 8 frames and 10 review files per bundle (same counts as the removed ones). Generated files stayed untracked/ignored; I reverted the re-encoded MP4/poster.Not verified
qc:buildand the full unit suite were not run locally; only the files-enumerating checks above.🤖 Generated with Claude Code