Editorial: remove nested Queue a task around message dispatch in Client.postMessage - #1844
Merged
monica-ch merged 1 commit intoAug 12, 2026
Merged
Conversation
…nt.postMessage The fire messageerror and Dispatch message steps already run inside a task on |destination|'s client message queue, so wrapping them in an additional Queue a task on |targetClient|'s responsible event loop is redundant (both queues target the destination client's event loop) and potentially incorrect (the outer client message queue task source is superseded by the inner DOM manipulation task source). This reverts the Client.postMessage changes from w3c#1836, per @asutherland's post-merge feedback on that PR. The Clients.get and Clients.claim changes from w3c#1836 are unaffected.
monica-ch
marked this pull request as ready for review
August 5, 2026 22:25
Collaborator
Author
|
@asutherland @yoshisatoyanagisawa Will you take look, this reverts the recent change to Client.postMessage |
github-actions Bot
added a commit
to asleekgeek/ServiceWorker
that referenced
this pull request
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1836. Addresses @asutherland's comment.
Client.postMessage'sfire messageerrorandDispatch messagesteps already run insideAdd a task ... to |destination|'s client message queue, which runs on|targetClient|'s event loop. #1836 added an innerQueue a task on |targetClient|'s responsible event loop, using the DOM manipulation task sourcearound each step, which:postMessageneeds.This PR removes the two inner wrappers.
Clients.getandClients.claimfrom #1836 are unchanged.Preview | Diff