Repository navigation
Boundary register: verify cross-boundary identifiers against records #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
17f4825
feat: boundary register - verify cross-boundary identifiers against r…
jmc-wander 548a3fd
feat: pact boundary cite - produce records, never type a digest or line
jmc-wander 7cc1cb5
fix: align boundary-register/1 token and placeholder rules with facto…
jmc-wander d8e2207
release: 1.3.0 (boundary register, pact boundary verify/cite)
jmc-wander File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| # REVIEW.md -- Pact | ||
|
|
||
| Guidance for automated review of Pact changes. Architecture and commands: `CLAUDE.md`. | ||
|
|
||
| ## Always check | ||
|
|
||
| - Mechanical gates stay mechanical: no LLM call inside `contracts.py`, | ||
| `boundary_register.py`, `production_validation.py`, `analyzer.py`, or `checklist_gen.py`. | ||
| - New validation that is meant to block returns errors through `validate_all_contracts` | ||
| (or the production gate); it is never downgraded to a logged warning. | ||
| - Cross-boundary identifiers (names, tokens, roles, grants, metric/log fields, headers) | ||
| are never assumed: they come from `boundary_register.yaml` / `boundary_identifiers` | ||
| with records that verify. A register edited to fit a stale digest is a defect. | ||
| - Schema changes to `ComponentContract` and other persisted models load existing | ||
| `interface.json` files (new fields have defaults; malformed LLM data must not make a | ||
| contract unloadable). | ||
| - New behavior has pytest coverage under `tests/` that fails without the change; CLI | ||
| commands that gate exit non-zero on failure. | ||
| - Agent prompts keep the context fence as the first line and stay concise (no rule lists | ||
| appended to every prompt without need). | ||
| - Record/evidence paths are confined to the project root (no absolute paths, no `..`, | ||
| no symlink escape). | ||
|
|
||
| ## Style | ||
|
|
||
| - Several source files use CRLF or mixed line endings; edits must preserve them (no | ||
| whole-file EOL churn in diffs). | ||
| - Prefer stdlib; runtime dependencies are pydantic, pyyaml, pytest (see `pyproject.toml`). | ||
| - Docstrings state the why and the invariant a module upholds. | ||
| - Error messages name the artifact, entry, and reason so an operator can act without | ||
| reading code. | ||
|
|
||
| ## Skip | ||
|
|
||
| - `dist/`, `.pact/`, `.kin/`, generated `standards.json`, `tasks.json`, `TASKS.md`. | ||
| - `tests/smoke/` (generated by `pact adopt`). | ||
| - Local `config.yaml` operator tuning. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| """Pact — contract-first multi-agent software engineering.""" | ||
|
|
||
| __version__ = "1.2.0" | ||
| __version__ = "1.3.0" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Author is told to copy register entries verbatim, but reusing an entry id in boundary_identifiers trips the duplicate-id hard error; instruct 'reference, do not re-add' or tolerate identical copies.