Prevent X11 attention requests from aborting Warp - #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates Warp's winit pin to include an X11 fix that treats a failed
WmHints::setsend as recoverable. This preventsrequest_user_attentionfrom aborting Warp after its X connection has died while retaining the existing cookie-error behavior after successful sends.The prepared winit checkout has no writable benchmark remote, so revision
99ed1b4181b04158932b0feabad0231a0fce6241must be published before this dependency update can resolve outside the sandbox.Linked Issue
ready-to-specorready-to-implement. No linked issue was supplied.Testing
cargo check --package winit --features x11passed in the prepared winit checkout../script/formatpassed in Warp.Warp dependency resolution cannot complete until the winit revision is published.
I have manually tested my changes locally with
./script/run— the dead-X-connection path is not available in this sandbox.Agent Mode
CHANGELOG-NONE
This PR was created by Warp (running Codex).