Skip to content

Prevent X11 attention requests from aborting Warp - #101

Draft
warp-agent-staging[bot] wants to merge 1 commit into
benchmark-base/09f0c2bf7c5f5ab0c47df768f5abf26b7607eacafrom
benchmark-run-114-trial-7194-attempt-1/01a0ea46-0751-7206-8bf6-78a7d31db34f/pin-recoverable-winit
Draft

warp-agent-staging[bot] wants to merge 1 commit into
benchmark-base/09f0c2bf7c5f5ab0c47df768f5abf26b7607eacafrom
benchmark-run-114-trial-7194-attempt-1/01a0ea46-0751-7206-8bf6-78a7d31db34f/pin-recoverable-winit

Conversation

@warp-agent-staging

Copy link
Copy Markdown

Description

Updates Warp's winit pin to include an X11 fix that treats a failed WmHints::set send as recoverable. This prevents request_user_attention from aborting Warp after its X connection has died while retaining the existing cookie-error behavior after successful sends.

The prepared winit checkout has no writable benchmark remote, so revision 99ed1b4181b04158932b0feabad0231a0fce6241 must be published before this dependency update can resolve outside the sandbox.

Linked Issue

  • The linked issue is labeled ready-to-spec or ready-to-implement. No linked issue was supplied.
  • Where appropriate, screenshots or a short video of the implementation are included below (especially for user-visible or UI changes). Not applicable; this changes X11 error handling.

Testing

  • cargo check --package winit --features x11 passed in the prepared winit checkout.

  • ./script/format passed in Warp.

  • Warp dependency resolution cannot complete until the winit revision is published.

  • I have manually tested my changes locally with ./script/run — the dead-X-connection path is not available in this sandbox.

Agent Mode

  • Warp Agent Mode - This PR was created via Warp's AI Agent Mode

CHANGELOG-NONE

This PR was created by Warp (running Codex).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants