Skip to content

feat: add call events to voice call record - #77

Merged
wavekat-eason merged 1 commit into
mainfrom
feat/call-events
Oct 18, 2026
Merged

wavekat-eason merged 1 commit into
mainfrom
feat/call-events

Conversation

@wavekat-eason

Copy link
Copy Markdown
Contributor

Adds the wire types the daemon needs to sync a call's event timeline to the platform, plus two booking fields the platform already accepts.

Changes

  • New VoiceCallEvent { at_ms, kind, state?, status?, digit? }, exported from the crate root.
    • These are the events the desktop's call page lists under "Events": rang, connected, you answered or declined (with the SIP status), keys you pressed.
    • kind is a plain String, as on VoiceCallFlowStep, so a newer daemon's kind still deserializes.
    • at_ms counts from ring time.
  • VoiceCallRecord.events: Option<Vec<VoiceCallEvent>>: skipped on the wire when None.
  • VoiceCallFlowStep.count / .start: booking details (book_offered count, booked slot).
    • The platform has accepted both since the booking work.
    • This crate had no fields for them, so the daemon was dropping them.

Compatibility

  • Wire: additive only. All new fields are optional, with #[serde(default)] and skip_serializing_if.
  • Rust API: adding public struct fields is a breaking change for consumers that build these structs literally. In 0.0.x every bump is already semver-incompatible, so wavekat-voice has to add events: None / count: None, start: None when it bumps. That change is already written in its PR.

Tests

  • New fixture tests/fixtures/voice_call/v0.0.37.json, round-tripped. It carries events and booking details.
  • New tests assert that v0.0.36 reads with all new fields None, and that an event with an unknown kind and an extra field still deserializes.
  • cargo test --all-features and cargo clippy --all-targets --all-features are clean.

Release train

  1. wavekat/wavekat-platform#449 (migration)
  2. wavekat/wavekat-platform#450 (API + UI)
  3. This PR, then publish (expected 0.0.37)
  4. wavekat-voice bumps to it and sends the fields.

@wavekat-eason
wavekat-eason marked this pull request as ready for review October 18, 2026 07:03
@wavekat-eason
wavekat-eason merged commit 0943c0b into main Oct 18, 2026
1 check passed
@wavekat-eason
wavekat-eason deleted the feat/call-events branch October 18, 2026 07:25
@github-actions github-actions Bot mentioned this pull request Oct 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant