chore: align AI agent roster with EFT Viewer scope - #12
Merged
Merged
Conversation
Initial sync of the agency-agents library brought in 179 profiles across 17 categories, most of which don't fit a C#/.NET desktop fingerprint viewer. This narrows the roster to roles that actually apply and expands the agent-teams registry accordingly. - Trim .claude/agency-config.json to the six relevant categories (design, engineering, product, project-management, specialized, testing) so future syncs stay scoped. - Remove 11 non-aligned category directories (academic, examples, finance, game-development, integrations, marketing, paid-media, sales, spatial-computing, strategy, support). - Prune individual profiles within kept categories that don't fit (e.g. web frontend, blockchain, embedded firmware, Feishu/WeChat, APIs, brand/whimsy design, Jira/studio PM, etc.). - Expand .claude/agent-teams.json with shortcodes covering the desktop/parser/CI/docs/UI/testing roles this project actually uses. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
wct097
commented
Apr 20, 2026
wct097
left a comment
Owner
Author
There was a problem hiding this comment.
Code review — approve with minor suggestions
Config-only scope-reduction PR. Every checklist item passes on HEAD.
Fact-check
- Both JSON files parse cleanly, end with trailing newlines.
synced_categoriesmatches dirs on disk (design, engineering, product, project-management, specialized, testing).- All 26 shortcode paths resolve to existing files.
- No empty directories under
.claude/agents/. - 28 personas on disk (matches PR claim).
- No secrets committed.
Suggestions
-
Two personas are orphaned (on disk but not registered in
agent-teams.json):.claude/agents/testing/testing-tool-evaluator.md.claude/agents/testing/testing-workflow-optimizer.md
Register or prune.
-
MOBscope question — retained for the future .NET MAUI roadmap per CLAUDE.md; defensible, just flag in description next time. -
Optional: no dedicated data/binary-format persona for ANSI/NIST-ITL + WSQ work.
SE+SAcover it for a solo dev; flag for future consideration.
Nits
- Key grouping in
agent-teams.jsonis by category (not alpha); grouping reads better — preserve on future edits.
Recommendation: address suggestion #1, then merge.
Register the two orphaned testing personas so every file under .claude/agents/ has a corresponding team shortcode. - TE → testing/testing-tool-evaluator.md - WO → testing/testing-workflow-optimizer.md Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.claude/agency-config.jsonto the six categories relevant to a C#/.NET desktop fingerprint viewer:design,engineering,product,project-management,specialized,testing..claude/agent-teams.jsonfrom 2 to 26 shortcodes covering the roles this project actually uses: desktop/parser engineering, mobile (future MAUI), security, DevOps/releases, technical writing, git workflow, code review, onboarding, minimal-change edits, rapid prototyping, reality checks, performance (WSQ decode), accessibility, test analysis, evidence collection, Avalonia UI/UX, inclusive visuals, product/sprint management, and document generation.Rationale
Initial agency-agents sync pulled 179 personas across 17 categories. Most were irrelevant to an OSS Avalonia desktop app parsing ANSI/NIST-ITL biometric files, and kept noise out of the agent registry. This PR narrows the roster to a curated set that maps cleanly to this project's surface area.
Test plan
.claude/agents/contains only aligned categories and profiles.claude/agents/.claude/agent-teams.jsonshortcodes resolve to existing files.claude/agency-config.jsonlists only the six retained categories🤖 Generated with Claude Code