Repository navigation
Conversation
Reuse the REST timeout helper with a five-second deadline for external OIDC requests. Cover cancellation at the deadline and timer cleanup after success. This addresses the auth-deadline part of issue weaviate#7; refresh retry behavior is unchanged.
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Infrastructure as Code | View in Orca | ||
| SAST | View in Orca | ||
| Secrets | View in Orca | ||
| Vulnerabilities | View in Orca |
|
To avoid any confusion in the future about your contribution to Weaviate, we work with a Contributor License Agreement. If you agree, you can simply add a comment to this PR that you agree with the CLA so that we can merge. |
Author
|
I agree to the Weaviate Contributor License Agreement. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OIDC discovery and token requests currently have no timeout. A provider can also return headers and then stall a JSON or error body, leaving authentication waiting indefinitely. This change applies a five-second deadline to each external auth GET/POST, including response-body consumption, and reports an abort through the existing
WeaviateRequestTimeoutError.Addresses the authentication-timeout portion of #7. Early token refresh and retry behavior from that issue remain separate work.
The private fetch helper accepts an optional response consumer so the auth deadline stays active through
checkStatus(true). Other REST calls andgetRawretain their existing header-deadline behavior. Timers are cleared on success or failure, and ordinary HTTP error classes are preserved. This is a per-request deadline, not a bound on the entire multi-step login.Validation
The existing timeout message's unit wording is unchanged; #480 addresses that separately.