perf: enable split chunks by default for Node.js builds - #8332
Conversation
Deploying rsbuild with
|
| Latest commit: |
1b515a4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2c3f22aa.rsbuild-v2.pages.dev |
| Branch Preview URL: | https://node-split-chunks.rsbuild-v2.pages.dev |
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 851308bfb9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fd1199d008
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
33e9e24 to
5e78e75
Compare
chenjiahan
changed the title
chenjiahan
changed the title
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1b515a4088
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
2 participants
Summary
This PR addresses the SSR module duplication reported in TanStack Router #8113.
Previously, Rsbuild disabled
splitChunksby default for Node.js builds. In applications that generate many server route chunks, such as TanStack Start, shared modules could therefore be bundled repeatedly into each route chunk, increasing the server output size, memory usage, and rebuild time.This PR:
splitChunksby default for Node.js builds withchunks: 'all'andminSize: 0.splitChunks: falseas an explicit opt-out.Breaking change
Node.js builds may now emit additional shared chunk files. Set
splitChunks: falseto restore the previous behavior.Related Links