ci: report binary size change on pull requests - #2081
Merged
Merged
Conversation
Contributor
Member
Author
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ff53febf97
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
fansenze
reviewed
Sep 20, 2026
fansenze
approved these changes
Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Nothing in CI tells a reviewer how much a pull request grows the binary. This reports it, with no added build and no repository configuration.
How it works
Test npm packagesalready compiles everything behind./cmd/rslint, so a release relink right afterBuildis link-only off the warm cache: 49s against 5m12s for a full build. It relinks rather than measuring the binary that job already produced, which is 52.20 MiB unstripped where the released one is 37.10 MiB.mainincluded, uploads its measurement as a workflow artifact. No repository writes, no token beyond the built-inGITHUB_TOKEN.mainrun for its base commit. The newBinary Sizejob reads both, writes the comparison to the job summary, and updates one pull request comment in place.The job is deliberately absent from
CI Done— porting a rule legitimately grows the binary, so this informs a review rather than blocking a merge.Limits
maintrend still needs somewhere durable to write.Related Links
Closes #2059
Checklist