fix(react): align jsx-key with upstream - #2161
Merged
Merged
Conversation
elecmonkey
marked this pull request as ready for review
September 14, 2026 09:36
fansenze
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
react/jsx-keycurrently misses key diagnostics for parenthesized JSX elements in arrays because the TypeScript AST preserves parentheses that ESTree omits.The rule also ignores file-level
@jsxpragmas when recognizingChildren.toArraycalls and constructing fragment diagnostics. This can produce false positives for custom JSX runtimes and recommend the wrong fragment name.Changes
@jsxpragmas when recognizingChildren.toArraycalls and constructing fragment diagnostics.settings.react.fragment, matching upstream behavior.eslint-plugin-react@7.37.5.