perf: optimize ESM library module concatenation - #15081
LingyuCoder wants to merge 2 commits into
Conversation
📦 Binary Size-limit
❌ Size increased by 48.00KB from 68.15MB to 68.19MB (⬆️0.07%) |
Rsdoctor Bundle Diff AnalysisFound 5 projects in monorepo, 0 projects with changes. 📊 Quick Summary
Generated by Rsdoctor GitHub Action |
Merging this PR will degrade performance by 2.01%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | rust@mangle_exports |
3.1 ms | 3.1 ms | -2.01% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing seal/concat-esm-library (14c08eb) with main (f7a86ea)
Footnotes
-
47 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
b055dc7 to
58c569e
Compare
004aa17 to
131ce67
Compare
5755934 to
0535be4
Compare
0535be4 to
c5e329d
Compare
c5e329d to
41075e4
Compare
92855ba to
00e7c85
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 00e7c85e21
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ee1ab8f to
14c08eb
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 14c08ebf2f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
This PR is stacked on #14852 and should be reviewed and merged after it.
Checks run:
cargo check -p rspack_plugin_esm_librarypnpm run build:binding:devpnpm run test -t "esmOutputCases/deconflict"pnpm run test -t "esmOutputCases/worker/new-url-relative"Related links
Checklist