Skip to content

revert: remove faster module concatenation - #15262

Merged
LingyuCoder merged 1 commit into
mainfrom
seal/revert-faster-module-concatenation
Aug 21, 2026
Merged

LingyuCoder merged 1 commit into
mainfrom
seal/revert-faster-module-concatenation

Conversation

@LingyuCoder

Copy link
Copy Markdown
Contributor

Summary

Related links

Validation

  • pnpm run build:binding:dev
  • pnpm run build:js
  • pnpm run test:unit
  • cargo clippy --workspace --all-targets --tests --locked -- -D warnings
  • cargo fmt --all -- --check
  • pnpm exec rs fmt --check

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying rspack with  Cloudflare Pages  Cloudflare Pages

Latest commit: e87a341
Status: ✅  Deploy successful!
Preview URL: https://ce580f3f.rspack-v2.pages.dev
Branch Preview URL: https://seal-revert-faster-module-co.rspack-v2.pages.dev

View logs

@github-actions

github-actions Bot commented Aug 21, 2026 •

Copy link
Copy Markdown
Contributor

📦 Binary Size-limit

Comparing 92101da to fix: refine binding code generation result error handling (#15253) by AsyncIter

🎉 Size decreased by 220.13KB from 68.26MB to 68.05MB (⬇️0.31%)

@github-actions

github-actions Bot commented Aug 21, 2026 •

Copy link
Copy Markdown
Contributor

Rsdoctor Bundle Diff Analysis

⚠️ Note: The latest commit (78186afa38) does not have baseline artifacts. Using commit 91384b1a7c for baseline comparison instead. If this seems incorrect, please wait a few minutes and try rerunning the workflow.

Found 5 projects in monorepo, 0 projects with changes.

📊 Quick Summary
Project Total Size Gzip Size Change Gzip Change
popular-libs 1.7 MB 556.5 KB 0 0
react-10k 5.6 MB 1.3 MB 0 0
react-1k 823.1 KB 218.4 KB 0 0
react-5k 2.7 MB 669.3 KB 0 0
ui-components 4.9 MB 1.4 MB 0 0

Generated by Rsdoctor GitHub Action

@codspeed

codspeed Bot commented Aug 21, 2026 •

Copy link
Copy Markdown
Contributor

Merging this PR will degrade performance by 19.11%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 3 regressed benchmarks
✅ 47 untouched benchmarks
⏩ 47 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Simulation rust@concatenate_module_code_generation 32.5 ms 44.4 ms -26.72%
❌ Simulation bundle@threejs-production-sourcemap 148.6 ms 191.8 ms -22.52%
❌ Simulation bundle@misc-production-sourcemap 3.3 s 3.6 s -6.77%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing seal/revert-faster-module-concatenation (92101da) with main (91384b1)

Open in CodSpeed

Footnotes

  1. 47 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@github-actions

github-actions Bot commented Aug 21, 2026 •

Copy link
Copy Markdown
Contributor

📝 Rspack Ecosystem CI: Open

suite result
rsbuild ✅ success
examples ❌ failure
rsdoctor ✅ success
modernjs ❌ failure
lynx-stack ❌ failure
rstest ❌ failure
rspress ✅ success
devserver ✅ success
plugin ✅ success
rsbuild-rsc-plugin ✅ success
rslib ✅ success

chenjiahan
chenjiahan previously approved these changes Aug 21, 2026
Reverts #14852 and #15247 while retaining the module code generation cache integration added afterward.
@LingyuCoder
LingyuCoder force-pushed the seal/revert-faster-module-concatenation branch from e87a341 to 92101da Compare August 21, 2026 08:08
@LingyuCoder
LingyuCoder enabled auto-merge (squash) August 21, 2026 08:46
@LingyuCoder
LingyuCoder merged commit 5e383af into main Aug 21, 2026
46 of 47 checks passed
@LingyuCoder
LingyuCoder deleted the seal/revert-faster-module-concatenation branch August 21, 2026 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants