fix: correct TabbedPane swipe and close method names - #1190
Open
laurenic0l wants to merge 4 commits into
Open
laurenic0l wants to merge 4 commits into
laurenic0l wants to merge 4 commits into
Conversation
laurenic0l
requested review from
EHandtkeBasis,
MatthewHawkins,
bbrennanbasis,
gosteenBASIS and
hyyan
as code owners
October 2, 2026 06:33
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| 2. **Tooltip(`String`)**: The tooltip text that is associated with the `Tab`, which will be displayed when the cursor hovers over the `Tab`. | ||
|
|
||
| 3. **Tooltip(`String`)**: The tooltip text that is associated with the `Tab`, which will be displayed when the cursor hovers over the `Tab`. | ||
| 3. **Enabled(`boolean`)**: Represents whether the `Tab` is currently enabled or not. Can be modified with the `setEnabled(boolean enabled)` method. |
Contributor
There was a problem hiding this comment.
📝 [vale] <Google.Timeless> reported by reviewdog 🐶
Avoid time-based words like 'currently' in product documentation.
| 3. **Enabled(`boolean`)**: Represents whether the `Tab` is currently enabled or not. Can be modified with the `setEnabled(boolean enabled)` method. | ||
|
|
||
| 4. **Enabled(`boolean`)**: Represents whether the `Tab` is currently enabled or not. Can be modified with the `setEnabled(boolean enabled)` method. | ||
| 4. **Closable(`boolean`)**: Represents whether the `Tab` can be closed. Can be modified with the `setClosable(boolean closable)` method. This will add a close button on the `Tab` which can be clicked on by the user, and fires a removal event. The `TabbedPane` component dictates how to handle the removal. |
Contributor
There was a problem hiding this comment.
'Represents' should be in lowercase.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
| ## Usages {#usages} | ||
|
|
||
| The `TabbedPane` class is a gives developers a powerful tool for organizing and presenting multiple tabs or sections within a UI. Here are some typical scenarios where you might utilize a `TabbedPane` in your application: | ||
| The `TabbedPane` class is gives developers a powerful tool for organizing and presenting multiple tabs or sections within a UI. Here are some typical scenarios where you might use a `TabbedPane` in your application: |
Contributor
There was a problem hiding this comment.
Use 'app' instead of 'application'.
Suggested change
| The `TabbedPane` class is gives developers a powerful tool for organizing and presenting multiple tabs or sections within a UI. Here are some typical scenarios where you might use a `TabbedPane` in your application: | |
| The `TabbedPane` class is gives developers a powerful tool for organizing and presenting multiple tabs or sections within a UI. Here are some typical scenarios where you might use a `TabbedPane` in your app: |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
| 1. **Text(`String`)**: The text that will be displayed as a title for the `Tab` within the `TabbedPane`. This is also referred to as the title via the `getTitle()` and `setTitle(String title)` methods. | ||
|
|
||
| 2. **Text(`String`)**: The text that will be displayed as a title for the `Tab` within the `TabbedPane`. This is also referred to as the title via the `getTitle()` and `setTitle(String title)` methods. | ||
| 2. **Tooltip(`String`)**: The tooltip text that's associated with the `Tab`, which will be displayed when the cursor hovers over the `Tab`. |
Contributor
There was a problem hiding this comment.
'The' should be in lowercase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1164
Corrections to the TabbedPane article:
setSwipable→setSwipeableandsetSwipableWithMouse→setSwipeWithMousesetCloseable→setClosable, and the property renamed to ClosablegetKey()is package-private with no setter, so it isn't publicly readable or writable, which the section's lead-in claims of everything listed.Two small extras while I was in the file: dropped "keys" from the frontmatter description, since it made the same claim in the meta description, and finished an incomplete sentence in the Inserting a
Tabsection.