Repository navigation
feat!: ship the admin templates as the default theme - #42
Merged
Merged
Conversation
Moves templates/admin to templates/default/admin so the default theme owns them, and points the ConfigProvider template path and its expected-config fixture at it. Signed-off-by: Joey Smith <jsmith@webinertia.net>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
templates/default/admin)Checklist:
1.0.x: this package is untagged.)Description
Part of the theme port,
webinertia/webware-themespecs/001-theme-resolution/task T057 (FR-018). Movestemplates/admintotemplates/default/adminand pointsConfigProvider::getTemplates()and the integration fixture at it. The dashboard template carries no IMS markup, so nothing else changes.How has this been tested?
mago format --check,lint,analyze,guardexit 0.composer test: 24 tests.composer test-integration: 11 tests.