Skip to content

fix: align the session table collation with the rest of the fleet #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tyrsson merged 1 commit into from
Oct 5, 2026
Merged

fix: align the session table collation with the rest of the fleet #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Session/Console/Schema/SessionSchema.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ public function sessionTable(string $table): CreateTable
$createTable->setOptions(options: [
'engine' => new Literal(literal: 'InnoDB'),
'default charset' => new Literal(literal: 'utf8mb4'),
'collate' => new Literal(literal: 'utf8mb4_unicode_ci'),
'collate' => new Literal(literal: 'utf8mb4_0900_ai_ci'),
]);

return $createTable;
Expand Down
4 changes: 2 additions & 2 deletions test/unit/Session/Console/Schema/SessionSchemaTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ public function sessionTableOptionsSetEngineCharsetAndCollation(): void
self::assertInstanceOf(Literal::class, $options['engine']);
self::assertSame('InnoDB', $options['engine']->getLiteral());
self::assertSame('utf8mb4', $options['default charset']->getLiteral());
self::assertSame('utf8mb4_unicode_ci', $options['collate']->getLiteral());
self::assertSame('utf8mb4_0900_ai_ci', $options['collate']->getLiteral());
}

#[Test]
Expand All @@ -90,7 +90,7 @@ public function sessionTableRendersTheExactStatement(): void
. '`expires_at` DATETIME NOT NULL , '
. 'PRIMARY KEY (`id`), '
. 'INDEX `idx_expires_at`(`expires_at`) '
. ') ENGINE = InnoDB DEFAULT CHARSET = utf8mb4 COLLATE = utf8mb4_unicode_ci',
. ') ENGINE = InnoDB DEFAULT CHARSET = utf8mb4 COLLATE = utf8mb4_0900_ai_ci',
$sql,
);
}
Expand Down
Loading