Repository navigation
test: cover the resolver factories - #6
Merged
Merged
Conversation
ThemeResolverFactory and AggregateResolverFactory had no tests, which left 16 lines of the resolver PR uncovered. Adds unit tests for both, including the attach priorities. Signed-off-by: Joey Smith <jsmith@webinertia.net>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
Checklist:
Description
ThemeResolverFactoryandAggregateResolverFactoryhad no tests, which left 16 lines of the resolver PR (#4) uncovered and is whycodecov/patchfailed there. Adds unit tests for both, including the exact attach priorities (100, 50, 1).How has this been tested?
mago format --check,lint,analyze,guardexit 0. Line coverage 100% (67/67), 49 unit tests, mutation testing 62/62 killed, MSI 100%.