Repository navigation
chore: onboard webware-validator from the Webware skeleton - #2
Merged
Merged
Conversation
- rename the package to webware/webware-validator (composer name, description, keywords, extra.laminas.config-provider) - move both PSR-4 roots to Webware\Validator, WebwareTest\Validator and WebwareTestIntegration\Validator, with namespaces and file headers - update the copilot-instructions title and rebuild the README header with the real badges - require webware/webware-tools ^1.0.0-beta.8 - add a direct getDependencies() assertion so the public accessor is not an escaped PublicVisibility mutant (MSI 95 floor in webware-ci.json) Signed-off-by: Joey Smith <jsmith@webinertia.net>
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
Checklist:
Description
Onboards
webinertia/webware-validator(T0 ofwebware-usermanager/docs/agent-plan-admin-create-user.md), which was the unrenamedwebware/skeleton.composer.json— namewebware/webware-validator, new description and keywords,extra.laminas.config-provider→Webware\Validator\ConfigProvider, both PSR-4 roots (Webware\Validator\→src/,WebwareTest\Validator\→test/unit/,WebwareTestIntegration\Validator\→test/integration/).src/,test/— namespaces,usestatements and file headers..github/copilot-instructions.md— title line.README.md— title, description and the real (un-fenced) badge block; the skeleton's "Using this template" checklist is dropped, as it documents the template rather than this package.composer.json/composer.lock—webware/webware-tools^1.0.0-beta.3→^1.0.0-beta.8.test/unit/ConfigProviderTest.php— one added test that callsConfigProvider::getDependencies()directly.Motivation and Context
webware-validatormust exist as a real package beforePasswordRequirement(T1) can be added to it.The test is not cosmetic: Infection generates a
PublicVisibilitymutant onConfigProvider::getDependencies()(public → protected) that the existing__invoke()test cannot kill, leaving Covered Code MSI at 75% against the 95 floor declared inwebware-ci.json. Asserting the public accessor directly kills it.How has this been tested?
All gates run on the WSL host with mago 1.51.0, the version pinned by webware-tools
1.0.0-beta.8:mago fmt --checkmago lintmago analyzemago guardcomposer testcomposer test-integrationcomposer mutation-testgit grep -i skeletonreturns nothing outsidecomposer.lock.Screenshots (if appropriate):
n/a