Repository navigation
Rename the skeleton to the Webware application - #1
Merged
Merged
Conversation
- composer name webware/skeleton -> webware/webware, with a description and keywords for an application rather than a package starter - PSR-4 Webware\Skeleton\ (src/) -> App\ (src/App/src/), matching the App\ shape the centre mago.toml perimeter already expects - autoload-dev roots -> AppTest\ (test/unit) and AppTestIntegration\ (test/integration); the suite directories stay as the preset artifact has them - extra.laminas.config-provider -> App\ConfigProvider, still guarded by the wiring test - README title, description and badges now carry this repo's own coordinates, and the spent template rename checklist is removed - file headers drop the "Skeleton package" name - composer.lock content hash refreshed Gates: mago format --check, lint, analyze, guard clean; unit + integration suites green. Signed-off-by: Joey Smith <jsmith@webinertia.net>
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Works the first item of the skeleton build: the template rename. The repo was created from
repo-templateand still identified aswebware/skeleton; this makes it identify as the application it is.What changed
namewebware/skeletonwebware/webwaredescription/keywordsWebware\Skeleton\→src/App\→src/App/src/WebwareTest\Skeleton\,WebwareTestIntegration\Skeleton\AppTest\(test/unit),AppTestIntegration\(test/integration)extra.laminas.config-providerWebware\Skeleton\ConfigProviderApp\ConfigProviderREADME.md.github/copilot-instructions.md# webware/skeleton — …# webware/webware — …File headers drop the "Webware Skeleton package" name.
composer.lockonly had its content hash refreshed.Decisions
App\adopted forsrc/. This matches what the centremago.tomlperimeter already allows (App\**\Http\**alongside theWebware\**roots) and the shapetyrsson/mezzio-bleeding-edgeuses. The template'sWebware\Skeleton\root is gone.test/unitandtest/integration. The suite names are part of the tooling contract (composer testpins--testsuite "unit test"), sophpunit.xml.distkeeps parity with the canonical preset artifact instead of diverging totest/AppTest/.extra.laminas.config-provideris retained (pointed atApp\ConfigProvider) so the existing integration wiring test keeps guarding composer's declaration. It becomes redundant once the app's ownconfig/config.phpaggregator lands, and can be dropped then.LICENSEneeded no change — the holder is alreadyWebinertia, not the template name.Scope
Rename only, deliberately.
config/,public/,bin/and the Mezzio/webware dependency block are not here — those come frommezzio-bleeding-edgeas needed, per the build order.Verification
mago fmt --check,mago lint,mago analyze,mago guard— all clean.phpunit --testsuite "unit test"— 1 test, 1 assertion, OK.phpunit --testsuite "integration test"— 1 test, 1 assertion, OK (the wiring test confirms composer'sconfig-providermatchesApp\ConfigProvider).webware/webware-tools 1.0.0-beta.3resolved from Packagist.Follow-ups (not in this PR)
webware-ci.jsonstill carries library gates (enable_infection: true,min_msi: 95); on an application skeleton that is the likely first red required-CI run and needs a deliberate decision.