fix: green up CI (xdebug extension, icon fixture)#15
Merged
Conversation
The `test` job on main was failing with 7 errors and 1 warning. - CI installed pcov, but `ExceptionHandlerTest` calls `xdebug_get_headers()`, which only exists when Xdebug is loaded. Switched `coverage` to `xdebug` and set `xdebug.mode="develop,coverage"` so both the header inspection and coverage work. - `DebuggerTest::testIconPathOption` pointed at `../guide/image.png`, which does not exist in this repository, so `renderDebugbar()` threw `LogicException: Icon not found`. Repointed at `src/Views/exceptions/favicons/development.png`, a real PNG that is not the default debugbar icon, so the option is still meaningfully exercised. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
testjob on main was failing with 7 errors and 1 warning.ExceptionHandlerTestcallsxdebug_get_headers(), which only exists when Xdebug is loaded. Switchedcoveragetoxdebugand setxdebug.mode="develop,coverage"so both the header inspection and coverage work.DebuggerTest::testIconPathOptionpointed at../guide/image.png, which does not exist in this repository, sorenderDebugbar()threwLogicException: Icon not found. Repointed atsrc/Views/exceptions/favicons/development.png, a real PNG that is not the default debugbar icon, so the option is still meaningfully exercised.🤖 Generated with Claude Code