[DEV-6821]fix(gotd/session.go): start gotd Client run in sepperate - #169
Open
suifri wants to merge 1 commit into
Open
[DEV-6821]fix(gotd/session.go): start gotd Client run in sepperate#169suifri wants to merge 1 commit into
suifri wants to merge 1 commit into
Conversation
coroutine Firs of all gotd client require internet connection to open WS conect to Telegram servers. As client that reported of this case use firewall configuration that blocked this connection - service didn`t start properely, cause gotd client use infinity reconnect mechanism and block service initialization and registration in service discovery provider. To handle this I decided to open new coroutine and initialized gotd client in this routine. See: https://github.com/gotd/contrib/blob/master/bg/connect.go#L95 What changed: - add creation of new coroutine in init of gotd cient session - add context and channel handling in gotd init coroutine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
coroutine
Firs of all gotd client require internet connection to open WS conect to Telegram servers. As client that reported of this case use firewall configuration that blocked this connection - service didn`t start properely, cause gotd client use infinity reconnect mechanism and block service initialization and registration in service discovery provider. To handle this I decided to open new coroutine and initialized gotd client in this routine.
See: https://github.com/gotd/contrib/blob/master/bg/connect.go#L95
What changed: