fix: tell the user why a nested queue add did nothing [WTEL-10406] - #1504
Merged
Merged
Conversation
…tps://webitel.atlassian.net/browse/WTEL-10406) Adding a skill, bucket, resource or hook to an unsaved queue saves the queue first, through the card's own validated `save`. When that validation fails the save returns silently, and the errors it raises render on the General or Parameters tab — which the nested tab is covering. So the add button did nothing at all, with no hint as to why. A failed validation now raises a toast. A rejected request stays silent, since the api transformer already notifies for it — saying it twice would read as two separate faults. The provider body moves into `createEnsureQueueSaved`, taking the card's pieces as callbacks, so the branch is unit-testable: the card page component itself is not, under @vue/compat. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
dlohvinov
deleted the
fix/WTEL-10406/queue-nested-add-validation-toast
branch
September 14, 2026 07:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WTEL-10406
Problem
On a new queue, pressing add on the Skills, Buckets, Resources or Hooks tab did nothing and said nothing.
Those tabs cannot add a record before the queue exists, so they first save the queue through the card's own
save. That save validates, anduseCardSaveActionreturns silently when validation fails. The field errors it raises are on the General / Parameters tab, which the nested tab is covering — so from the user's side the button is simply dead.Fix
A save blocked by validation now raises an error toast: "Fill in the required queue fields before adding records" (translated into all nine locales).
A save blocked by a rejected request stays silent — the api
notifytransformer already toasts for that, and a second toast would read as two separate faults.The provider body moved into
createEnsureQueueSaved, taking the card's pieces as callbacks. The card page component is untestable under@vue/compat(VTU stubs are inert there), the factory is not.Verification
Dev server against
test.webitel.me, new inbound queue with an empty name:Saved queue (
/queues/15/skills) is unaffected: add opens the "Add skill" popup, no toast.npx vitest run src/app/locale src/modules/contact-center/modules/queues— 109 passed (14 new: 5 on the factory, 9 on locale coverage)npm run typecheck— cleannpx biome check— clean🤖 Generated with Claude Code