feat(system_settings): apply changes without page refresh (WTEL-10322) - #497
Open
casual-dev1234 wants to merge 1 commit into
Open
feat(system_settings): apply changes without page refresh (WTEL-10322)#497casual-dev1234 wants to merge 1 commit into
casual-dev1234 wants to merge 1 commit into
Conversation
Publish a domain-wide system_settings websocket event on setting create/update/patch so every logged-in user in the domain applies the change without refreshing the page.
engine emits system_settings.{domainId} on the app exchange; the per-domain queue binds it (no user_id) and the hub broadcasts a system_settings ws event to all sessions. The payload carries only the changed setting names; clients re-fetch through the existing API.
Contributor
🤖 Webitel Code ReviewЦей пул-реквест додає механізм сповіщення клієнтів через WebSocket про зміни в системних налаштуваннях (system settings). Тепер при створенні, оновленні або частковому оновленні (patch) системного налаштування генерується подія в чергу повідомлень RabbitMQ, яка потім транслюється всім активним WebSocket-з'єднанням відповідного домену. Також було спрощено та узагальнено логіку порівняння значень налаштувань за допомогою глибокого порівняння розпарсеного JSON, що дозволяє уникнути помилкових спрацьовувань при зміні форматування або порядку ключів. 📋 Walkthrough (9 файл(и/ів))
Знахідки
🔗 Cross-repo callers змінених символів (5)
Index-grounded review across the Webitel codebase. Знахідки можуть бути неточними — перевіряйте перед застосуванням. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Publish a domain-wide system_settings websocket event on setting create/update/patch so every logged-in user in the domain applies the change without refreshing the page.
engine emits system_settings.{domainId} on the app exchange; the per-domain queue binds it (no user_id) and the hub broadcasts a system_settings ws event to all sessions. The payload carries only the changed setting names; clients re-fetch through the existing API.