fix(quick_reply): substring search without requiring '*' - #501
Open
casual-dev1234 wants to merge 1 commit into
Open
fix(quick_reply): substring search without requiring '*'#501casual-dev1234 wants to merge 1 commit into
casual-dev1234 wants to merge 1 commit into
Conversation
Quick reply search matched only when the caller supplied a '*' wildcard, because the shared q handling merely maps '*' -> '%'. A bare term like "мо" became ILIKE 'мо' (exact match) and returned nothing. Wrap the q term in '%...%' for both Quick reply query paths (GetAllPage and GetAllPageByAgentPriority) so it matches a substring anywhere in the name/text by default. The wrapping is local to Quick reply and preserves nil-when-empty so the ":Q isnull" guard still disables the filter. WTEL-10364
Contributor
🤖 Webitel Code ReviewЦей комміт додає автоматичне обгортання пошукового запиту у символи 📋 Walkthrough (1 файл(и/ів))
Суттєвих зауважень немає. 👍 Index-grounded review across the Webitel codebase. Знахідки можуть бути неточними — перевіряйте перед застосуванням. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick reply search matched only when the caller supplied a '' wildcard, because the shared q handling merely maps '' -> '%'. A bare term like "мо" became ILIKE 'мо' (exact match) and returned nothing.
Wrap the q term in '%...%' for both Quick reply query paths (GetAllPage and GetAllPageByAgentPriority) so it matches a substring anywhere in the name/text by default. The wrapping is local to Quick reply and preserves nil-when-empty so the ":Q isnull" guard still disables the filter.
WTEL-10364