[WTEL-10383]feature(broker): add creating system online skill on new - #502
Open
suifri wants to merge 1 commit into
Open
[WTEL-10383]feature(broker): add creating system online skill on new#502suifri wants to merge 1 commit into
suifri wants to merge 1 commit into
Conversation
Contributor
🤖 Webitel Code ReviewЦей пулреквест додає обробник подій створення домену для автоматичного створення системних навичок (online skills) для нових доменів. Для цього реалізовано новий загальний споживач черг RabbitMQ ( 📋 Walkthrough (10 файл(и/ів))
Знахідки
🔸 Дрібниці / nitpicks (1)
🔗 Cross-repo callers змінених символів (14)
Index-grounded review across the Webitel codebase. Знахідки можуть бути неточними — перевіряйте перед застосуванням. |
![webitel-review[bot]](https://avatars.githubusercontent.com/in/4658759?s=60&v=4){kind=small}
| ) | ||
|
|
||
| type DomainEvent struct { | ||
| ID int |
Contributor
There was a problem hiding this comment.
Використовуйте int64 для ID домену для узгодженості з рештою кодової бази.
Suggested change
| ID int | |
| ID int64 |
|
|
||
| const domainIdIndex = 2 | ||
|
|
||
| parsedDomainId, err := strconv.Atoi(splitted[domainIdIndex]) |
Contributor
There was a problem hiding this comment.
Парсинг ID домену як int64.
Suggested change
| parsedDomainId, err := strconv.Atoi(splitted[domainIdIndex]) | |
| parsedDomainId, err := strconv.ParseInt(splitted[domainIdIndex], 10, 64) |
| ch, err := b.getChannel() | ||
| if err != nil { | ||
| b.log.Error("getting AMQP channel", wlog.Err(err)) | ||
| if !b.sleep() { |
Contributor
There was a problem hiding this comment.
Передавайте контекст у метод sleep для швидкого реагування на скасування.
Suggested change
| if !b.sleep() { | |
| if !b.sleep(ctx) { |
|
|
||
| if err := b.setup(ch); err != nil { | ||
| b.log.Error("setup queue", wlog.Err(err)) | ||
| if !b.sleep() { |
Contributor
There was a problem hiding this comment.
Передавайте контекст у метод sleep.
Suggested change
| if !b.sleep() { | |
| if !b.sleep(ctx) { |
|
|
||
| if err != nil { | ||
| b.log.Error("consuming queue deliveries", wlog.Err(err)) | ||
| if !b.sleep() { |
Contributor
There was a problem hiding this comment.
Передавайте контекст у метод sleep.
Suggested change
| if !b.sleep() { | |
| if !b.sleep(ctx) { |
| Delete(ctx context.Context, deleteCmd *model.DeleteSkillPresetCmd) model.AppError | ||
| Search(ctx context.Context, search *model.SearchOnlineSkillsQuery) ([]*model.OnlineSkills, model.AppError) | ||
| Get(ctx context.Context, search *model.GetSkillPresetQuery) (*model.OnlineSkills, model.AppError) | ||
| CreateSystem(cxt context.Context, domainID int) model.AppError |
Contributor
There was a problem hiding this comment.
Виправлення типу domainID на int64 та імені контексту на ctx.
Suggested change
| CreateSystem(cxt context.Context, domainID int) model.AppError | |
| CreateSystem(ctx context.Context, domainID int64) model.AppError |
| return result, nil | ||
| } | ||
|
|
||
| func (s *SqlOnlineSkillsStore) CreateSystem(ctx context.Context, domainID int) model.AppError { |
Contributor
There was a problem hiding this comment.
Зміна типу domainID на int64.
Suggested change
| func (s *SqlOnlineSkillsStore) CreateSystem(ctx context.Context, domainID int) model.AppError { | |
| func (s *SqlOnlineSkillsStore) CreateSystem(ctx context.Context, domainID int64) model.AppError { |
suifri
force-pushed
the
feature/WTEL-10383-default-system-online-skill-creation-on-domain-init
branch
from
September 10, 2026 09:15
f1e0a34 to
fc11f74
Compare
Comment on lines
+203
to
+204
| app.MessageQueue.Start() | ||
| app.initDomainEventListener() |
Contributor
There was a problem hiding this comment.
Ініціалізуйте слухач подій доменів перед запуском черги повідомлень, щоб уникнути втрати подій, які вже є в черзі на момент старту.
Suggested change
| app.MessageQueue.Start() | |
| app.initDomainEventListener() | |
| app.initDomainEventListener() | |
| app.MessageQueue.Start() |
suifri
force-pushed
the
feature/WTEL-10383-default-system-online-skill-creation-on-domain-init
branch
2 times, most recently
from
September 10, 2026 09:51
45108e6 to
1b685ca
Compare
domain event - add creation of simple topic broker queue - add queue configuration object - add new domain created handler
suifri
force-pushed
the
feature/WTEL-10383-default-system-online-skill-creation-on-domain-init
branch
from
September 10, 2026 12:45
1b685ca to
3ffdcb7
Compare
| if len(splitted) < 3 { | ||
| return nil, NewBadRequestError( | ||
| "model.domain.new_domain_event.invalid_rk_len", | ||
| "received roting key with len less than 3", |
Contributor
There was a problem hiding this comment.
Виправлення друкарської помилки
Suggested change
| "received roting key with len less than 3", | |
| "received routing key with len less than 3", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
domain event