WTEL-10232: sort member communications in ReadMember - #503
Open
casual-dev1234 wants to merge 1 commit into
Open
Conversation
Contributor
🤖 Webitel Code ReviewЦей коміт додає нові gRPC-структури SearchMemberCommunicationRequest та ListOfMemberCommunication до згенерованого файлу member.pb.go. Зміни є результатом регенерації protobuf-файлів і не несуть ризиків зворотній сумісності. 📋 Walkthrough (1 файл(и/ів))
Суттєвих зауважень немає. 👍 🔗 Cross-repo callers змінених символів (18)
Index-grounded review across the Webitel codebase. Знахідки можуть бути неточними — перевіряйте перед застосуванням. |
Dedicated list endpoint that returns a member's communications sorted by name/type/priority (standard sort field), mirroring SearchListCommunication. Reuses Member.SortCommunications; ReadMember is left unchanged.
casual-dev1234
force-pushed
the
feat/WTEL-10232/member-communications-sort
branch
from
September 10, 2026 13:31
2d46576 to
dabf77f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Member.SortCommunications and apply it in ReadMember when the new communications_sort field is set. Sortable by name (destination), type and priority, both directions; nil entries last. Regenerate gen.