Conversation
Saizan
force-pushed
the
issue160
branch
7 times, most recently
from
August 26, 2026 15:07
110e08b to
4af9485
Compare
Saizan
marked this pull request as ready for review
August 26, 2026 15:33
Saizan
force-pushed
the
issue160
branch
4 times, most recently
from
August 27, 2026 11:26
ce5238b to
5daa7a7
Compare
alt-romes
reviewed
Aug 27, 2026
alt-romes
left a comment
alt-romes
left a comment
Collaborator
There was a problem hiding this comment.
I'm still going through the patch, but I think there are a few misnomers which complicated reasoning a lot! I've pointed them all out.
alt-romes
reviewed
Aug 27, 2026
Collaborator
|
Excellent work addressing the review! I'm much happier with it now. Small thing: could you make the export list of |
alt-romes
approved these changes
Aug 28, 2026
Collaborator
|
Land it when you're ready 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is working on 9.14.1 atm.
TODO:
bcoArgsOffset#362There's a couple more TODOs in the diff, I would like some input there.