chore(deps): override vite, esbuild and uuid to their patched releases - #71
Merged
Merged
Conversation
All five open Dependabot alerts on this repository resolve to three transitive
packages, and none of them can be reached by bumping what package.json declares:
vitepress 1.6.4 ──> vite 5.4.21 ──> esbuild 0.21.5
vite-plugin-top-level-await 1.6.0 ──> uuid 10.0.0 (an exact pin, not a range)
vitepress 1.6.4 is the newest stable release and constrains vite to ^5.4.14, so
there is no version of the declared dependencies that pulls a patched vite. The
2.x line exists only as 2.0.0-alpha.19 and would pull vite ^8. That leaves an
override as the only way to clear these without shipping an alpha.
vite ^6.4.3 server.fs.deny bypass on Windows alternate paths (high),
path traversal in optimized-deps .map handling, and the
launch-editor NTLMv2 hash disclosure on Windows
esbuild ^0.25.0 dev server accepts requests from any website
uuid ^11.1.1 missing buffer bounds check in v3/v5/v6 when buf is given
All three are development-scope: they are build tooling and never reach the
static output Cloudflare serves. The two Windows-specific ones do apply to the
machine this site is developed on, which is why this is worth doing rather than
dismissing.
Verified rather than assumed. `npm run build` succeeds against the overridden
tree, and its output was compared against a baseline build from the unmodified
dependencies: 16 HTML pages both times, 5.4M both times, and an identical file
set apart from one content hash on the lightweight-charts chunk, which is what a
different minifier version is expected to produce. `npm ci` resolves the
lockfile cleanly, which is what the Cloudflare build runs.
Deploying webpage with
|
| Latest commit: |
05d637f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://02c0e9b4.webpage-2vc.pages.dev |
| Branch Preview URL: | https://chore-override-vulnerable-de.webpage-2vc.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clears all five open Dependabot alerts.
Why an override and not a bump
None of the three vulnerable packages is declared in
package.json:vitepress@1.6.4is the newest stable release, and it constrains vite to^5.4.14. No version of the declared dependencies pulls a patched vite. The 2.xline exists only as
2.0.0-alpha.19and would pull vite^8. So an override isthe only way to clear these without shipping an alpha of the site framework.
vite^6.4.3server.fs.denybypass on Windows alternate paths; plus path traversal in optimized-deps.maphandling and the launch-editor NTLMv2 hash disclosureesbuild^0.25.0uuid^11.1.1bufis providedAll three are development scope — build tooling that never reaches the static
output Cloudflare serves. Worth doing anyway: two of the vite issues are
Windows-specific and this site is developed on Windows.
Verified, not assumed
npm run buildsucceeds against the overridden tree, and the output was comparedagainst a baseline build from the unmodified dependencies:
distsizelightweight-chartschunkThat single differing hash is what a different minifier version is expected to
produce, not a missing or changed asset. The WASM demo bundle
(
wickra_wasm_bg.*.wasm) is present in both.npm ci --dry-runresolves the lockfile cleanly, which is what the Cloudflarebuild runs — and the Cloudflare Pages check on this PR builds the site for real.