Conversation
2 tasks
JumpLink
added a commit
to gjsify/gjsify
that referenced
this pull request
Sep 25, 2026
gjsify filed wingtk/gvsbuild#1849 (libmpg123 project, from the gjsify/gvsbuild fork's add-mpg123 branch) so the win32 runtime bundle can decode MP3 through mpg123audiodec like darwin already does. gvsbuild only accepts a new library if the contributor keeps it current, and the PR body takes that on — so this is a standing task (bump version + sha256 on upstream mpg123 releases, answer breakage reports), not a one-time patch. Record it in status/upstream-patch-candidates.md, and update the open-todos entry that used to say nobody had filed it. Claude-Session: https://claude.ai/code/session_015AhJTvRNKM8BJrLm1TaADc
JumpLink
added a commit
to gjsify/gjsify
that referenced
this pull request
Sep 25, 2026
gjsify filed wingtk/gvsbuild#1849 (libmpg123 project, from the gjsify/gvsbuild fork's add-mpg123 branch) so the win32 runtime bundle can decode MP3 through mpg123audiodec like darwin already does. gvsbuild only accepts a new library if the contributor keeps it current, and the PR body takes that on — so this is a standing task (bump version + sha256 on upstream mpg123 releases, answer breakage reports), not a one-time patch. Record it in status/upstream-patch-candidates.md, and update the open-todos entry that used to say nobody had filed it. Claude-Session: https://claude.ai/code/session_015AhJTvRNKM8BJrLm1TaADc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an
mpg123project (libmpg123 1.33.7, built with its CMake port) and makesgst-plugins-gooddepend on it, so the GStreamermpg123plugin (mpg123audiodec) is built on Windows.Why
What
gvsbuild/projects/mpg123.py: the library only (BUILD_SHARED_LIBS=ON,BUILD_LIBOUT123=OFF; the CMake port builds the programs only on Unix). It installsmpg123.dll,libmpg123.pcand the licence (LGPL-2.1).gst-plugins-goodgetsmpg123as a dependency, the same waylibvpxis handled. Meson'smpg123option isauto, so it is picked up through pkg-config.How it was tested
gvsbuild build --ninja-opts -j2 --skip libvpx mpg123 gst-plugins-goodon awindows-2022runner (VS 2022) in a fork.lib\gstreamer-1.0\gstmpg123.dllis produced andgst-inspect-1.0 mpg123listsmpg123audiodec.filesrc ! mpegaudioparse ! mpg123audiodec ! audioconvert ! fakesinkdecodes a test MP3.Side note:
--skip libvpxwas needed because libvpx does not currently build onwindows-2022(mv: cannot stat 'x64/vpxmd.lib'inpost_install). That happens without this change as well, and the CI here doesn't build it. Run with the failure: https://github.com/gjsify/gvsbuild/actions/runs/36099329626I'm happy to keep the mpg123 project up to date.
🤖 Generated with Claude Code