feat(deps): add explicit build dependencies - #534
Closed
skhaz wants to merge 34 commits into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Architectural decision for review
This PR introduces
ns.build_dependencyas an explicit source/build-time edge instead of extendingns.dependencywithbind: false.The explicit kind is intentional and is the main decision requested from the reviewer:
ns.dependencyplusbind: falseas a normal runtime dependency and bind backend entries accidentally.ns.build_dependency, so they cannot silently reinterpret the edge as runtime-bound.requires_wippy, making the feature requirement explicit and fail-closed in supported CLIs.Semantics
build_only: no runtime path reaches the module.build_dependency: at least one build path reaches the module.requires_wippy.Publishing contract
Published consumers are closed artifacts:
ns.build_dependencyentries are removed before normalization and packaging.fe_provenancemetadata.Compatibility
ns.dependencybehavior is preserved.sha256:values.Scope boundary
This PR is the runtime dependency/update/install/publish foundation.
fe-install,fe-check, frontend ABI validation, and Hub server-authoritative redistribution are intentionally handled by follow-up implementation rather than hidden inside the dependency primitive.Verification
make testgo test ./boot/deps/config ./boot/deps/lock ./boot/deps/hub ./cmd/internal/entries ./cmd/wippy/cmd -count=1git diff --check 0fe48f50..HEADThe implementation went through five independent dual-review rounds. The final round identified workspace replacement loading in the actual publish command; that finding was fixed and the complete harness was rerun. The review iteration cap is now exhausted, so this PR intentionally leaves the final architectural approval to the human reviewer.