fix: Dialog - prevent open animation interruption by residual touch on Android - #4038
Open
Yoavpagir wants to merge 4 commits into
Open
fix: Dialog - prevent open animation interruption by residual touch on Android#4038Yoavpagir wants to merge 4 commits into
Yoavpagir wants to merge 4 commits into
Conversation
…n Android (minDistance) A bottom Dialog/ActionSheet opened from a gesture-driven trigger (e.g. List.Item's TapGestureHandler firing onPress on END) can rest part-way open on Android: the residual touch leaks into the Dialog's own panGesture and drives `visibility` mid-open, interrupting the open spring. Adding a minDistance activation threshold to the pan prevents a near-static residual touch from engaging it, while drag-to-dismiss keeps working. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
✅ PR Description Validation PassedAll required sections are properly filled out:
Your PR is good for review! 🚀 This validation ensures all sections from the PR template are properly filled. |
Yoavpagir
marked this pull request as ready for review
August 2, 2026 07:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On Android, a bottom-direction
Dialog(and thereforeActionSheet, which builds on it) can open only part-way — resting below its final position with just the header visible — when it is opened as a direct result of a gesture-driven trigger (e.g.List.Item, whoseTapGestureHandlerfiresonPresson gesture END while the touch is still settling). A plain touchable trigger (e.g.Button) lifts cleanly before the modal mounts and is unaffected.Root cause: the Dialog's own
panGesturehas no activation threshold, so on Android the residual touch stream from the triggering gesture leaks into the freshly-mounted pan and drivesvisibilitymid-open, interrupting thewithSpring(1)open animation. Because the translation isinterpolate(visibility, [0,1], [hiddenLocation, 0], CLAMP), an interruptedvisibility(< 1) leaves the card translated part-way down. Dismiss is unaffected (the residual touch is long gone by then), which is why the close animation always plays from the full height.Fix: add
.minDistance(10)to the DialogpanGestureso it only engages on a deliberate drag. A residual, near-static touch can no longer activate the pan and overwritevisibility, while drag-to-dismiss (movement well beyond the threshold) keeps working unchanged.Changelog
Dialog/ActionSheet: fixed the bottom sheet occasionally opening part-way on Android when triggered from a gesture-based component (e.g.
List.Item); the open animation is no longer interrupted by the triggering touch.Additional info
Under investigation for MOBAPP-2994 (Wix OneApp — "Mute Notifications" ActionSheet opening partially on Android). Draft while verifying on-device via the standard snapshot → wrapper → app build flow.