Repository navigation
Tighten unwrap, key pair generation and encapsulation checks - #243
Open
aidangarske wants to merge 230 commits into
Open
aidangarske wants to merge 230 commits into
aidangarske wants to merge 230 commits into
Conversation
aidangarske
force-pushed
the
fenrir-fixes-4271-8658
branch
2 times, most recently
from
October 9, 2026 02:00
2ad445b to
97bb7d3
Compare
aidangarske
force-pushed
the
fenrir-fixes-4271-8658
branch
from
October 10, 2026 03:20
97bb7d3 to
101fe0a
Compare
Frauschi
reviewed
Oct 13, 2026
aidangarske
force-pushed
the
fenrir-fixes-4271-8658
branch
from
October 13, 2026 22:19
101fe0a to
eb0959b
Compare
aidangarske
force-pushed
the
fenrir-fixes-4271-8658
branch
2 times, most recently
from
October 13, 2026 22:50
8511d4b to
023f3df
Compare
aidangarske
force-pushed
the
fenrir-fixes-4271-8658
branch
from
October 13, 2026 23:47
a4dcc48 to
44be119
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
F-4271- 5af17b9 - C_UnwrapKey now returns CKR_WRAPPED_KEY_LEN_RANGE for a wrapped key length that does not fit in 32 bits, before allocating either work buffer.F-8658- c9c4c4d - C_UnwrapKey now returns the CKR_WRAPPED_KEY codes for AES and RSA decrypt failures, and the RSA path rejects a blob that is not the modulus size before allocating.F-13246- 07db9a1 - C_GenerateKeyPair now sets the initial states for both keys before calling AddObject.F-10390- 94a7d59 - C_GenerateKeyPair now performs the common label copy before adding the public key and checks the result, returning CKR_DEVICE_MEMORY or CKR_FUNCTION_FAILED on failure.F-6659- 317bb77 - The CKM_HKDF_KEY_GEN case in C_GenerateKey is now guarded by WOLFPKCS11_HKDF and returns CKR_MECHANISM_INVALID when HKDF keys are compiled out.F-4635- 848f4d4 - C_DecapsulateKey now returns CKR_ARGUMENTS_BAD for an ML-KEM ciphertext length that does not fit in 32 bits.F-6960- 6163dcc - C_EncapsulateKey and C_DecapsulateKey now call CheckPrivateLogin so a user login is required when the new secret is private, including when CKA_PRIVATE is left at its default.F-11519- 97bb7d3 - GetRsaExponentValue now accumulates in an unsigned long, and WP11_Rsa_GenerateKeyPair rejects an exponent above LONG_MAX.Merge order for this stack (each PR is stacked on the previous one):