Skip to content

Replace blocking handoffs with advisory attention notices - #52

Merged
wolfiesch merged 1 commit into
mainfrom
fix/advisory-attention-notices
Sep 8, 2026
Merged

Replace blocking handoffs with advisory attention notices#52
wolfiesch merged 1 commit into
mainfrom
fix/advisory-attention-notices

Conversation

@wolfiesch

Copy link
Copy Markdown
Owner

Why

Human assistance should use chat for coordination. The extension reminder must not prevent an agent from inspecting the page, doing other work, or finishing its task while it waits for a reply.

Changes

  • Replace blocking handoff state with task-owned attention notices and request, status, resolve, and dismiss operations.
  • Remove handoff-based command and cleanup gates, including restart restoration paths.
  • Replace the required completion button with optional Open tab and Dismiss controls. Dismissal and expiry do not report successful completion.
  • Preserve notice ownership, stale-ID isolation, explicit Pause, sensitive-field protections, and configured Commit review.
  • Queue tab-local capture cleanup behind admitted same-tab work and preserve existing permissive-mode and credential-broker settings.
  • Update schemas, SDKs, adapters, migration coverage, and active documentation together.

Verification

Passed on this branch:

  • bun run workspace:typecheck
  • bun run --cwd packages/sdk-typescript build
  • bun test packages/extension/test packages/omp/test packages/mcp/test packages/sdk-typescript/test packages/gpt-control-driver/test
  • bun run extension:build
  • cargo test -p agenttab-protocol -p agenttab-host from host-rs
  • Python SDK tests and tests/architecture/verify_protocol_schemas.py
  • Browser-driven built-popup fixture covering the attention notice, Dismiss, explicit Pause, and Developer-mode revocation.

This PR remains draft pending the real-profile activation check.1

Footnotes

  1. The updated extension has not yet been activated in the real Chrome profile. Fixture checks do not establish end-to-end live-profile correctness. Remaining verification is to load the matching bundle, create a notice, exercise commands while it stays open, resolve it after inspecting the completed page condition, and finish the task without popup acknowledgement.

@wolfiesch
wolfiesch marked this pull request as draft September 8, 2026 01:59
@wolfiesch
wolfiesch marked this pull request as ready for review September 8, 2026 02:01
@wolfiesch
wolfiesch merged commit cb43cc6 into main Sep 8, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant