Link refund policy from disputes-and-refunds docs; fix _site tracking regression - #1546
Merged
Merged
Conversation
Adds a short "Our refund policy" section stating the general rule (completed/accepted work is non-refundable, with the usual fraud/duplicate/undelivered carve-outs) and points to the Refunds clause now in the Terms of Service (#1545), so the practical debit/credit mechanics on this page sit next to the policy they implement. There's no direct URL for the Terms of Service in the app today — it opens as an in-page dialog from the site footer's "Legal" menu rather than living at its own route — so the link points to gitpay.me with that noted, instead of a fabricated deep link.
The previous attempt at this (in #1543) added .gitignore's _site/ entry but the removal itself got reverted by an in-progress `git reset` while splitting that PR into commits, so the merge ended up re-committing _site/ anyway — with my local validation build's output baked in (Jekyll v3.10.0, localhost:4000 canonical URLs), which is worse than the original stale copy it was meant to replace. This time: a plain `git rm -r --cached _site`, committed immediately, nothing in between to undo it. Verified the diff below is 202 pure deletions with no other changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two things:
_docs/en/disputes-and-refunds.md, stating the general rule and linking to the new Refunds clause in the Terms of Service (worknenjoy/gitpay#1545, companion PR againstmaster)._site/is still tracked ongh-pagesafter that PR merged, and worse, its content is now my local validation build's output (Jekyll v3.10.0,localhost:4000canonical URLs) rather than either being removed or left alone.Why
_site/came back#1543 intended to untrack
_site/(git rm -r --cached _site, documented in that PR's first commit). While splitting that work into logical commits afterward, I rangit resetto reorganize staged changes — which unstaged that removal — then re-staged withgit add -A _site .gitignorefor a later commit. Since_site/was tracked again at that point (the reset restored it) and had changed on disk (from my own localjekyll buildruns during validation),git add -Aupdated the tracked copy instead of removing it. The.gitignoreentry from the same PR is correct and does stop future untracked builds from being added, but it doesn't retroactively untrack a path that's already back in the index.This time:
git rm -r --cached _site, committed immediately with nothing in between to undo it. Verified the commit is 202 pure deletions and nothing else, and that a freshbundle exec jekyll buildafterward leavesgit statusclean (confirming_site/stays untracked going forward).Validation
bundle exec jekyll build— succeeds.git statusafter the build — clean (no_site/changes reappear).htmlproofer ./_site --disable-external --checks Links,Scripts,Images— 0 failures._siteremoval commit (git show --stat) to confirm 202 files, all deletions, no other paths touched.🤖 Generated with Claude Code
https://claude.ai/code/session_01PtCXQDsoFovaYbCxvdjua2
Generated by Claude Code