feat(generated)!: SDK surface change: Symbol "IntentOptions" was removed (+4 more)#697
feat(generated)!: SDK surface change: Symbol "IntentOptions" was removed (+4 more)#697workos-sdk-automation[bot] wants to merge 7 commits into
Conversation
…cationIntentOptions" was removed
Greptile SummaryThis PR regenerates the SDK after several schema symbols were removed. The main changes are:
Confidence Score: 4/5Additional public imports break beyond the five announced symbol removals.
src/workos/common/models/init.py, src/workos/common/init.py, and src/workos/sso/models/init.py Important Files Changed
Prompt To Fix All With AIFix the following 2 code review issues. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 2
src/workos/common/models/__init__.py:109
**Surviving Model Exports Disappear**
This removes package-level exports for models that still exist and are used by sibling models, including `AuthenticationRadarRiskDetectedDataAction`, `DirectoryUserState`, and `EventContextActorSource`. Code using the supported named-import form `from workos.common.models import EventContextActorSource` now fails with `ImportError`, expanding the breaking surface beyond the five announced removals.
### Issue 2 of 2
src/workos/sso/models/__init__.py:4
**Unannounced SSO Export Removal**
Removing this re-export and deleting its module makes `from workos.sso.models import ConnectionOption` fail on upgrade. `ConnectionOption` is not among the five breaking removals listed in this PR, so existing callers receive an undocumented `ImportError` with no stated replacement.
Reviews (1): Last reviewed commit: "chore(generated): add release notes frag..." | Re-trigger Greptile |
| @@ -109,7 +109,6 @@ | |||
| from .authenticate_response_impersonator import ( | |||
There was a problem hiding this comment.
Surviving Model Exports Disappear
This removes package-level exports for models that still exist and are used by sibling models, including AuthenticationRadarRiskDetectedDataAction, DirectoryUserState, and EventContextActorSource. Code using the supported named-import form from workos.common.models import EventContextActorSource now fails with ImportError, expanding the breaking surface beyond the five announced removals.
Context Used: CLAUDE.md (source)
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/workos/common/models/__init__.py
Line: 109
Comment:
**Surviving Model Exports Disappear**
This removes package-level exports for models that still exist and are used by sibling models, including `AuthenticationRadarRiskDetectedDataAction`, `DirectoryUserState`, and `EventContextActorSource`. Code using the supported named-import form `from workos.common.models import EventContextActorSource` now fails with `ImportError`, expanding the breaking surface beyond the five announced removals.
**Context Used:** CLAUDE.md ([source](https://app.greptile.com/workos/github/workos/workos-python/-/custom-context?memory=3d138293-80e5-449b-bb68-0972a12bbb9d))
How can I resolve this? If you propose a fix, please make it concise.|
|
||
| from .connection import Connection as Connection | ||
| from .connection_option import * # noqa: F401,F403 | ||
| from .connection_domain import ConnectionDomain as ConnectionDomain |
There was a problem hiding this comment.
Unannounced SSO Export Removal
Removing this re-export and deleting its module makes from workos.sso.models import ConnectionOption fail on upgrade. ConnectionOption is not among the five breaking removals listed in this PR, so existing callers receive an undocumented ImportError with no stated replacement.
Context Used: CLAUDE.md (source)
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/workos/sso/models/__init__.py
Line: 4
Comment:
**Unannounced SSO Export Removal**
Removing this re-export and deleting its module makes `from workos.sso.models import ConnectionOption` fail on upgrade. `ConnectionOption` is not among the five breaking removals listed in this PR, so existing callers receive an undocumented `ImportError` with no stated replacement.
**Context Used:** CLAUDE.md ([source](https://app.greptile.com/workos/github/workos/workos-python/-/custom-context?memory=3d138293-80e5-449b-bb68-0972a12bbb9d))
How can I resolve this? If you propose a fix, please make it concise.
Summary
feat(admin_portal)!: SDK surface change: Symbol "IntentOptions" was removed
feat(connect)!: SDK surface change: Symbol "ConnectedAccountDto" was removed
feat(organization_domains)!: SDK surface change: Symbol "DomainVerificationIntentOptions" was removed
feat(pipes)!: SDK surface change: Symbol "DataIntegrationCredentialsDto" was removed
feat(sso)!: SDK surface change: Symbol "SSOIntentOptions" was removed
Triggered by workos/openapi-spec@eda9449
BEGIN_COMMIT_OVERRIDE
feat(admin_portal)!: SDK surface change: Symbol "IntentOptions" was removed (#697)
feat(connect)!: SDK surface change: Symbol "ConnectedAccountDto" was removed (#697)
feat(organization_domains)!: SDK surface change: Symbol "DomainVerificationIntentOptions" was removed (#697)
feat(pipes)!: SDK surface change: Symbol "DataIntegrationCredentialsDto" was removed (#697)
feat(sso)!: SDK surface change: Symbol "SSOIntentOptions" was removed (#697)
END_COMMIT_OVERRIDE